[PR #435] [MERGED] fix: don't exit with fping host is unreachable #479

New issue

Closed

opened 2026-05-07 00:21:06 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:06 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/435
Author: @speed47
Created: 12/4/2023
Status: ✅ Merged
Merged: 12/5/2023
Merged by: @speed47

Base: master ← Head: alive

📝 Commits (1)

93a43f8 fix: don't exit with fping host is unreachable

📊 Changes

3 files changed (+11 additions, -9 deletions)

View changed files

📝 bin/plugin/open/alive (+4 -8)
📝 tests/functional/launch_tests_on_instance.sh (+4 -1)
📝 tests/functional/tests.d/360-plugins.sh (+3 -0)

📄 Description

As ping can return unknown exit codes for unknown cases, just never bail out to avoid taking bad decisions, as we retry each second maximum, there's no DoS risk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/435 **Author:** [@speed47](https://github.com/speed47) **Created:** 12/4/2023 **Status:** ✅ Merged **Merged:** 12/5/2023 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `alive` --- ### 📝 Commits (1) - [`93a43f8`](https://github.com/ovh/the-bastion/commit/93a43f8e0bc1be3c90b50852fa7f42d4101d6623) fix: don't exit with fping host is unreachable ### 📊 Changes **3 files changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `bin/plugin/open/alive` (+4 -8) 📝 `tests/functional/launch_tests_on_instance.sh` (+4 -1) 📝 `tests/functional/tests.d/360-plugins.sh` (+3 -0) </details> ### 📄 Description As ping can return unknown exit codes for unknown cases, just never bail out to avoid taking bad decisions, as we retry each second maximum, there's no DoS risk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>