[PR #504] [MERGED] Correction of error message and documentation #534

New issue

Closed

opened 2026-05-07 00:21:23 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:23 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/504
Author: @TomRicci
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/23/2024
Merged by: @speed47

Base: master ← Head: master

📝 Commits (10+)

572589e fix: message protocol in ACL.pm
24d6e62 fix: message scpdownload scpupload in upgrading.rst
ac902b8 fix: message scpdownload scpupload in sftp_scp_rsync.rst
d22a3cf fix: message scpdownload scpupload in accountDelPersonalAccess
99ac650 fix: message scpdownload scpupload in selfAddPersonalAccess
2513ba9 fix: message scpdownload scpupload in selfDelPersonalAccess
a9e38f1 fix: message scpdownload scpupload in accountAddPersonalAccess
4fdba5f fix: message scpdownload scpupload in groupAddGuestAccess
b2d4463 fix: message scpdownload scpupload in groupDelGuestAccess
11e43a9 fix: message scpdownload scpupload in scp

📊 Changes

19 files changed (+67 additions, -66 deletions)

View changed files

📝 bin/plugin/group-gatekeeper/groupAddGuestAccess (+4 -4)
📝 bin/plugin/group-gatekeeper/groupDelGuestAccess (+4 -4)
📝 bin/plugin/open/scp (+2 -2)
📝 bin/plugin/restricted/accountAddPersonalAccess (+4 -4)
📝 bin/plugin/restricted/accountDelPersonalAccess (+4 -4)
📝 bin/plugin/restricted/selfAddPersonalAccess (+4 -4)
📝 bin/plugin/restricted/selfDelPersonalAccess (+4 -4)
📝 doc/sphinx-plugins-override/scp.override.rst (+2 -2)
📝 doc/sphinx/installation/upgrading.rst (+1 -1)
📝 doc/sphinx/plugins/group-gatekeeper/groupAddGuestAccess.rst (+4 -4)
📝 doc/sphinx/plugins/group-gatekeeper/groupDelGuestAccess.rst (+4 -4)
📝 doc/sphinx/plugins/open/scp.rst (+2 -2)
📝 doc/sphinx/plugins/restricted/accountAddPersonalAccess.rst (+4 -4)
📝 doc/sphinx/plugins/restricted/accountDelPersonalAccess.rst (+4 -4)
📝 doc/sphinx/plugins/restricted/selfAddPersonalAccess.rst (+4 -4)
📝 doc/sphinx/plugins/restricted/selfDelPersonalAccess.rst (+4 -4)
📝 doc/sphinx/using/sftp_scp_rsync.rst (+3 -3)
📝 lib/perl/OVH/Bastion/Plugin/ACL.pm (+2 -1)
📝 tests/functional/tests.d/395-mfa-scp-sftp-rsync.sh (+7 -7)

📄 Description

There were an issue with the error message when trying to add a server with --protocol scpdown or --protocol scpup (instead of the correct --protocol scpdownload or --protocol scpupload) :

The protocol 'scpup' is not supported, expected either scpup, scpdown, sftp or rsync

Similarly the documentation was wrong on the correct syntaxe for those kind of calls.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/504 **Author:** [@TomRicci](https://github.com/TomRicci) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/23/2024 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`572589e`](https://github.com/ovh/the-bastion/commit/572589ef361547ab8dcab2eabb1440cd5406f54e) fix: message protocol in ACL.pm - [`24d6e62`](https://github.com/ovh/the-bastion/commit/24d6e626e182537d3fda552d69a5a0e5eaab46f1) fix: message scpdownload scpupload in upgrading.rst - [`ac902b8`](https://github.com/ovh/the-bastion/commit/ac902b8f10e42ceb9a2c561c200b8eb3dba6e3f1) fix: message scpdownload scpupload in sftp_scp_rsync.rst - [`d22a3cf`](https://github.com/ovh/the-bastion/commit/d22a3cfe3670f5475ce6354ec847f0de07dee499) fix: message scpdownload scpupload in accountDelPersonalAccess - [`99ac650`](https://github.com/ovh/the-bastion/commit/99ac6508bcecdaef6606a2efc2064513dfc27eea) fix: message scpdownload scpupload in selfAddPersonalAccess - [`2513ba9`](https://github.com/ovh/the-bastion/commit/2513ba979799ac65a35e5cec535448be894b2503) fix: message scpdownload scpupload in selfDelPersonalAccess - [`a9e38f1`](https://github.com/ovh/the-bastion/commit/a9e38f1db02e6aad00e5fe08ca354c456176f880) fix: message scpdownload scpupload in accountAddPersonalAccess - [`4fdba5f`](https://github.com/ovh/the-bastion/commit/4fdba5f25e229b3ce2672f10e09f5329a6a181f4) fix: message scpdownload scpupload in groupAddGuestAccess - [`b2d4463`](https://github.com/ovh/the-bastion/commit/b2d446327d1d30680abadc7d5bc9adb66aab140e) fix: message scpdownload scpupload in groupDelGuestAccess - [`11e43a9`](https://github.com/ovh/the-bastion/commit/11e43a94d7411cf04e13c0dd08743384d84dc319) fix: message scpdownload scpupload in scp ### 📊 Changes **19 files changed** (+67 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `bin/plugin/group-gatekeeper/groupAddGuestAccess` (+4 -4) 📝 `bin/plugin/group-gatekeeper/groupDelGuestAccess` (+4 -4) 📝 `bin/plugin/open/scp` (+2 -2) 📝 `bin/plugin/restricted/accountAddPersonalAccess` (+4 -4) 📝 `bin/plugin/restricted/accountDelPersonalAccess` (+4 -4) 📝 `bin/plugin/restricted/selfAddPersonalAccess` (+4 -4) 📝 `bin/plugin/restricted/selfDelPersonalAccess` (+4 -4) 📝 `doc/sphinx-plugins-override/scp.override.rst` (+2 -2) 📝 `doc/sphinx/installation/upgrading.rst` (+1 -1) 📝 `doc/sphinx/plugins/group-gatekeeper/groupAddGuestAccess.rst` (+4 -4) 📝 `doc/sphinx/plugins/group-gatekeeper/groupDelGuestAccess.rst` (+4 -4) 📝 `doc/sphinx/plugins/open/scp.rst` (+2 -2) 📝 `doc/sphinx/plugins/restricted/accountAddPersonalAccess.rst` (+4 -4) 📝 `doc/sphinx/plugins/restricted/accountDelPersonalAccess.rst` (+4 -4) 📝 `doc/sphinx/plugins/restricted/selfAddPersonalAccess.rst` (+4 -4) 📝 `doc/sphinx/plugins/restricted/selfDelPersonalAccess.rst` (+4 -4) 📝 `doc/sphinx/using/sftp_scp_rsync.rst` (+3 -3) 📝 `lib/perl/OVH/Bastion/Plugin/ACL.pm` (+2 -1) 📝 `tests/functional/tests.d/395-mfa-scp-sftp-rsync.sh` (+7 -7) </details> ### 📄 Description There were an issue with the error message when trying to add a server with `--protocol scpdown` or `--protocol scpup` (instead of the correct `--protocol scpdownload` or `--protocol scpupload`) : ``` The protocol 'scpup' is not supported, expected either scpup, scpdown, sftp or rsync ``` Similarly the documentation was wrong on the correct syntaxe for those kind of calls. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>