[PR #519] [MERGED] enh: 35% faster is_valid_ip() when fast=1 #546

New issue

Closed

opened 2026-05-07 00:21:26 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:26 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/519
Author: @speed47
Created: 1/3/2025
Status: ✅ Merged
Merged: 1/3/2025
Merged by: @speed47

Base: master ← Head: faster_is_valid_ip

📝 Commits (2)

d2d47ba chore: use proper naming of 'subnet' instead of 'prefix' or 'slash'
82572e8 enh: 35% faster is_valid_ip() when fast=1

📊 Changes

33 files changed (+194 additions, -146 deletions)

View changed files

📝 bin/plugin/group-aclkeeper/groupAddServer (+3 -3)
📝 bin/plugin/group-aclkeeper/groupDelServer (+2 -2)
📝 bin/plugin/group-aclkeeper/groupSetServers (+2 -2)
📝 bin/plugin/group-gatekeeper/groupAddGuestAccess (+2 -2)
📝 bin/plugin/group-gatekeeper/groupDelGuestAccess (+2 -2)
📝 bin/plugin/open/alive (+1 -1)
📝 bin/plugin/open/mtr (+1 -1)
📝 bin/plugin/open/nc (+1 -1)
📝 bin/plugin/open/ping (+1 -1)
📝 bin/plugin/restricted/accountAddPersonalAccess (+4 -4)
📝 bin/plugin/restricted/accountDelPersonalAccess (+2 -2)
📝 bin/plugin/restricted/assetForgetHostKey (+2 -2)
📝 bin/plugin/restricted/selfAddPersonalAccess (+4 -4)
📝 bin/plugin/restricted/selfDelPersonalAccess (+2 -2)
📝 bin/shell/osh.pl (+6 -6)
📝 doc/sphinx/administration/configuration/bastion_conf.rst (+7 -7)
📝 doc/sphinx/plugins/group-aclkeeper/groupAddServer.rst (+2 -2)
📝 doc/sphinx/plugins/group-aclkeeper/groupDelServer.rst (+2 -2)
📝 doc/sphinx/plugins/group-gatekeeper/groupAddGuestAccess.rst (+2 -2)
📝 doc/sphinx/plugins/group-gatekeeper/groupDelGuestAccess.rst (+2 -2)

...and 13 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/519 **Author:** [@speed47](https://github.com/speed47) **Created:** 1/3/2025 **Status:** ✅ Merged **Merged:** 1/3/2025 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `faster_is_valid_ip` --- ### 📝 Commits (2) - [`d2d47ba`](https://github.com/ovh/the-bastion/commit/d2d47ba6cecb2697ebf4dd0f467ab1472cd43ea8) chore: use proper naming of 'subnet' instead of 'prefix' or 'slash' - [`82572e8`](https://github.com/ovh/the-bastion/commit/82572e887594ffc1b7c322bcbc6f6f9ff53a6f64) enh: 35% faster is_valid_ip() when fast=1 ### 📊 Changes **33 files changed** (+194 additions, -146 deletions) <details> <summary>View changed files</summary> 📝 `bin/plugin/group-aclkeeper/groupAddServer` (+3 -3) 📝 `bin/plugin/group-aclkeeper/groupDelServer` (+2 -2) 📝 `bin/plugin/group-aclkeeper/groupSetServers` (+2 -2) 📝 `bin/plugin/group-gatekeeper/groupAddGuestAccess` (+2 -2) 📝 `bin/plugin/group-gatekeeper/groupDelGuestAccess` (+2 -2) 📝 `bin/plugin/open/alive` (+1 -1) 📝 `bin/plugin/open/mtr` (+1 -1) 📝 `bin/plugin/open/nc` (+1 -1) 📝 `bin/plugin/open/ping` (+1 -1) 📝 `bin/plugin/restricted/accountAddPersonalAccess` (+4 -4) 📝 `bin/plugin/restricted/accountDelPersonalAccess` (+2 -2) 📝 `bin/plugin/restricted/assetForgetHostKey` (+2 -2) 📝 `bin/plugin/restricted/selfAddPersonalAccess` (+4 -4) 📝 `bin/plugin/restricted/selfDelPersonalAccess` (+2 -2) 📝 `bin/shell/osh.pl` (+6 -6) 📝 `doc/sphinx/administration/configuration/bastion_conf.rst` (+7 -7) 📝 `doc/sphinx/plugins/group-aclkeeper/groupAddServer.rst` (+2 -2) 📝 `doc/sphinx/plugins/group-aclkeeper/groupDelServer.rst` (+2 -2) 📝 `doc/sphinx/plugins/group-gatekeeper/groupAddGuestAccess.rst` (+2 -2) 📝 `doc/sphinx/plugins/group-gatekeeper/groupDelGuestAccess.rst` (+2 -2) _...and 13 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>