[PR #578] [MERGED] fix: dont return status code 1 if unlock-home.sh is already linked #585

New issue

Closed

opened 2026-05-07 00:21:38 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:21:38 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ovh/the-bastion/pull/578
Author: @jon4hz
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @speed47

Base: master ← Head: fix-encryption-exit-code

📝 Commits (1)

522e429 fix: dont return status code 1 if unlock-home.sh is already linked

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 bin/admin/setup-encryption.sh (+3 -1)

📄 Description

I'm not exactly sure how I got into this situation, but I managed to have this symlink in place, without having my disk encrypted (probably due to some testings I did).

At the moment, the script will always exit with status 1, if that symlink already exists. In my opinion, it should still exit with 0, but simply skip the ln command if the link already exists.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ovh/the-bastion/pull/578 **Author:** [@jon4hz](https://github.com/jon4hz) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@speed47](https://github.com/speed47) **Base:** `master` ← **Head:** `fix-encryption-exit-code` --- ### 📝 Commits (1) - [`522e429`](https://github.com/ovh/the-bastion/commit/522e4299fb9dd4159cc78ce6fb20efcf67ce9ae6) fix: dont return status code 1 if unlock-home.sh is already linked ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/admin/setup-encryption.sh` (+3 -1) </details> ### 📄 Description I'm not exactly sure how I got into this situation, but I managed to have this symlink in place, without having my disk encrypted (probably due to some testings I did). At the moment, the script will always exit with status `1`, if that symlink already exists. In my opinion, it should still exit with `0`, but simply skip the `ln` command if the link already exists. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>