mirror of
https://github.com/glenndehaan/unifi-voucher-site.git
synced 2026-05-09 08:25:29 +02:00
[GH-ISSUE #62] Allow for larger QR codes #29
Labels
No labels
bug
enhancement
pull-request
question
question
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/unifi-voucher-site#29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adrianipopescu on GitHub (Mar 12, 2025).
Original GitHub issue: https://github.com/glenndehaan/unifi-voucher-site/issues/62
Originally assigned to: @glenndehaan on GitHub.
The feature
When trying to use a 32-character long password for my wifi, I get:
The chosen QR Code version cannot contain this amount of data.
Minimum version required to store current data is: 5.
And the app crashes and reboots.
Would it be possible to support such scenarios?
@glenndehaan commented on GitHub (Mar 12, 2025):
Hi @adrianipopescu,
Well I didn't expect someone to do it, but you did.
When I designed the QR feature I needed to make a decision on how big the QR Code would be, and therefore how much data it could hold.
And I thought lets pick the middle ground: a somewhat limited but smaller QR but enough to either support larger SSID's or SSID's with a reasonable password.
But a 32 character password I was not expecting. Looking at the RFC it seems that the maximum amount of characters is 63.
I will have a look for next release to see if this fits the PDF and ESC/POS Print Versions. The email I'm not concerned about.
Some notes for myself:
@adrianipopescu commented on GitHub (Mar 12, 2025):
sorry
@glenndehaan commented on GitHub (Mar 13, 2025):
Hi @adrianipopescu,
Good News! I just released version 5.0.1, this included the path for the QR code generation when utilizing larger SSID's and/or Passwords.
@adrianipopescu commented on GitHub (Mar 13, 2025):
thank you for this!