mirror of
https://github.com/glenndehaan/unifi-voucher-site.git
synced 2026-05-09 08:25:29 +02:00
[GH-ISSUE #21] font color of Voucher code #6
Labels
No labels
bug
enhancement
pull-request
question
question
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/unifi-voucher-site#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aroundmyroom on GitHub (Dec 17, 2022).
Original GitHub issue: https://github.com/glenndehaan/unifi-voucher-site/issues/21
Originally assigned to: @glenndehaan on GitHub.
When accessing the application on an Iphone the colouring is changed during the evening to a black background.
But the code is not. It can be read but it is very dark grey so it is difficult to read in the screen.
example
@glenndehaan commented on GitHub (Dec 18, 2022):
Hey thanks for finding this issue. I'm usually on android so I didn't find this issue. I have pushed a fixed an tested in a webkit browser and it seems to be working now, can you confirm this after updating?
@aroundmyroom commented on GitHub (Dec 18, 2022):
Will need some more testing, cause in the afternoon/evening it will turn black (no clue how my iphone is handling that, never investages), but now I see that the colour on iphone in the morning also is to vague
@aroundmyroom commented on GitHub (Dec 18, 2022):
on a PC it looks ok
@glenndehaan commented on GitHub (Dec 18, 2022):
The app is taking over the system preferred-color-scheme. In other words: Does the use have dark-mode enabled or not. It seems you have it set to auto currently. You should be able to switch that inside your device preferences to auto, light or dark.
Looking at the image you just send I think you need to clear the cache of the browser because it is loading the old CSS
@glenndehaan commented on GitHub (Dec 18, 2022):
Oh also I forgot since you are running the code locally ensure you run the tailwind command again since this regenerates the CSS file
@glenndehaan commented on GitHub (Dec 18, 2022):
You can verify if the new code is there to inspect the input field and look for the -webkit-text-fill-color property. If that is not there then the CSS has not been recompiled or you are stuck in some browser cache
@aroundmyroom commented on GitHub (Dec 18, 2022):
looks wierd under my windows with chrome
looks different than from you and I did release cache and ran tailwinds
@glenndehaan commented on GitHub (Dec 18, 2022):
No that looks fine. But you have to look for the CSS part
@glenndehaan commented on GitHub (Dec 18, 2022):
Ahh wait, did you also ran a npm ci before the tailwind command? Because a new module was added.
@glenndehaan commented on GitHub (Dec 18, 2022):
This is basically the reason why I prefer people using the docker container since i'm remotely debugging one system
@aroundmyroom commented on GitHub (Dec 18, 2022):
will check tonight. did a new pull and changes the way it was listening to my port 80 (variable in server.js) So its now default code again. Probably it will look fine tonight.
@aroundmyroom commented on GitHub (Dec 21, 2022):
checked it, its readable, but still a little to grey-ish for my taste. But as nobody probably is giving tickets out by night it is fine ;)