[PR #1023] [MERGED] chore: remove useless code assertion tests and snaps #1026

New issue

Closed

opened 2026-05-06 13:11:38 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:11:38 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/1023
Author: @james-elicx
Created: 5/2/2026
Status: ✅ Merged
Merged: 5/2/2026
Merged by: @james-elicx

Base: main ← Head: claude/magical-saha-0c8f89

📝 Commits (3)

5afa5d7 chore: remove useless code assertion tests and snaps
ed144f0 .
c04217c knip issue

📊 Changes

13 files changed (+141 additions, -7912 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+1 -1)
📝 packages/vinext/src/server/app-page-element-builder.ts (+2 -2)
➖ tests/__snapshots__/entry-templates.test.ts.snap (+0 -6827)
📝 tests/app-router.test.ts (+33 -363)
📝 tests/build-optimization.test.ts (+0 -8)
📝 tests/build-time-classification-integration.test.ts (+3 -5)
📝 tests/client-reference-dedup.test.ts (+7 -14)
📝 tests/deploy.test.ts (+0 -74)
📝 tests/entry-templates.test.ts (+6 -401)
📝 tests/font-local-transform.test.ts (+49 -122)
📝 tests/image-imports.test.ts (+21 -47)
📝 tests/og-font-patch.test.ts (+12 -39)
📝 tests/og-inline.test.ts (+7 -9)

📄 Description

removing as they don't test functionality or behaviour / aren't providing value anymore.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/1023 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 5/2/2026 **Status:** ✅ Merged **Merged:** 5/2/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `claude/magical-saha-0c8f89` --- ### 📝 Commits (3) - [`5afa5d7`](https://github.com/cloudflare/vinext/commit/5afa5d75e78924feb8f8142602cbc024efeab5bf) chore: remove useless code assertion tests and snaps - [`ed144f0`](https://github.com/cloudflare/vinext/commit/ed144f0ee7fe5792b4988dee5a9c1ba61f34abaf) . - [`c04217c`](https://github.com/cloudflare/vinext/commit/c04217c5d3a8f8fac8823ff7ce8da9b1cb474b7a) knip issue ### 📊 Changes **13 files changed** (+141 additions, -7912 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+1 -1) 📝 `packages/vinext/src/server/app-page-element-builder.ts` (+2 -2) ➖ `tests/__snapshots__/entry-templates.test.ts.snap` (+0 -6827) 📝 `tests/app-router.test.ts` (+33 -363) 📝 `tests/build-optimization.test.ts` (+0 -8) 📝 `tests/build-time-classification-integration.test.ts` (+3 -5) 📝 `tests/client-reference-dedup.test.ts` (+7 -14) 📝 `tests/deploy.test.ts` (+0 -74) 📝 `tests/entry-templates.test.ts` (+6 -401) 📝 `tests/font-local-transform.test.ts` (+49 -122) 📝 `tests/image-imports.test.ts` (+21 -47) 📝 `tests/og-font-patch.test.ts` (+12 -39) 📝 `tests/og-inline.test.ts` (+7 -9) </details> ### 📄 Description removing as they don't test functionality or behaviour / aren't providing value anymore. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>