[PR #14] [MERGED] fix: don't tell users to run vinext init when already inside vinext init #243

New issue

Closed

opened 2026-05-06 12:38:44 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:38:44 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/14
Author: @southpolesteve
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @southpolesteve

Base: main ← Head: fix/check-init-messaging

📝 Commits (1)

e435b05 fix: don't tell users to run vinext init when already inside vinext init

📊 Changes

2 files changed (+15 additions, -13 deletions)

View changed files

📝 packages/vinext/src/check.ts (+14 -12)
📝 packages/vinext/src/init.ts (+1 -1)

📄 Description

Summary

When vinext init runs the compatibility check, the output says:

Missing "type": "module" — run vinext init to add it automatically
Recommended next steps: Run vinext init to set up your project

This is confusing because the user is already running vinext init.

Fix:

Change the detail text to "vinext init will add it automatically"
Skip the "Recommended next steps" block when called from init (init prints its own summary afterward)

Reported by Brandon Strittmatter during testing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/14 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `fix/check-init-messaging` --- ### 📝 Commits (1) - [`e435b05`](https://github.com/cloudflare/vinext/commit/e435b059a5ac7f44f7e63f13bde582212fa971d5) fix: don't tell users to run vinext init when already inside vinext init ### 📊 Changes **2 files changed** (+15 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/check.ts` (+14 -12) 📝 `packages/vinext/src/init.ts` (+1 -1) </details> ### 📄 Description ## Summary When `vinext init` runs the compatibility check, the output says: - `Missing "type": "module" — run vinext init to add it automatically` - `Recommended next steps: Run vinext init to set up your project` This is confusing because the user is already running `vinext init`. **Fix:** - Change the detail text to "vinext init will add it automatically" - Skip the "Recommended next steps" block when called from init (init prints its own summary afterward) Reported by Brandon Strittmatter during testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>