[PR #43] [CLOSED] fix(windows): use file:// URLs for absolute path imports #264

Closed
opened 2026-05-06 12:38:50 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/43
Author: @liuxiaopai-ai
Created: 2/25/2026
Status: Closed

Base: mainHead: fix/issue-23-windows


📝 Commits (1)

  • 1fcca37 fix: use file URLs for dynamic imports on Windows (#23)

📊 Changes

6 files changed (+114 additions, -17 deletions)

View changed files

📝 .github/workflows/ci.yml (+17 -0)
📝 packages/vinext/src/cli.ts (+2 -1)
📝 packages/vinext/src/index.ts (+12 -7)
packages/vinext/src/utils/import-path.ts (+32 -0)
tests/import-path.test.ts (+37 -0)
📝 tests/pages-router.test.ts (+14 -9)

📄 Description

Addresses #23.\n\n- Use pathToFileURL for Windows drive-letter absolute paths during dynamic import/module loading\n- Add unit tests for path conversion\n- Add windows-latest CI job (lint/typecheck/unit) to prevent regressions


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/43 **Author:** [@liuxiaopai-ai](https://github.com/liuxiaopai-ai) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/issue-23-windows` --- ### 📝 Commits (1) - [`1fcca37`](https://github.com/cloudflare/vinext/commit/1fcca370deb4590572dcf7c26715b5bc33bc8f66) fix: use file URLs for dynamic imports on Windows (#23) ### 📊 Changes **6 files changed** (+114 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+17 -0) 📝 `packages/vinext/src/cli.ts` (+2 -1) 📝 `packages/vinext/src/index.ts` (+12 -7) ➕ `packages/vinext/src/utils/import-path.ts` (+32 -0) ➕ `tests/import-path.test.ts` (+37 -0) 📝 `tests/pages-router.test.ts` (+14 -9) </details> ### 📄 Description Addresses #23.\n\n- Use pathToFileURL for Windows drive-letter absolute paths during dynamic import/module loading\n- Add unit tests for path conversion\n- Add windows-latest CI job (lint/typecheck/unit) to prevent regressions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:38:50 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#264
No description provided.