[PR #62] [MERGED] fix: make publish chat notification non-fatal #281

New issue

Closed

opened 2026-05-06 12:38:57 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:38:57 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/62
Author: @southpolesteve
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @southpolesteve

Base: main ← Head: fix/publish-webhook

📝 Commits (1)

4be67bb fix: make chat notification non-fatal and add charset to content-type

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 .github/workflows/publish.yml (+3 -2)

📄 Description

Summary

The Google Chat notification step failed on the first publish run (logs), which marked the entire workflow as failed even though the npm publish succeeded.

Two fixes:

continue-on-error: true — a failed notification should never fail the publish workflow
Content-Type: application/json; charset=UTF-8 — Google Chat API requires the charset; this is likely why the request was rejected (HTTP 4xx)
-fSs -o /dev/null -w "HTTP %{http_code}" — shows the HTTP status code in logs on failure instead of silently swallowing errors

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/62 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `fix/publish-webhook` --- ### 📝 Commits (1) - [`4be67bb`](https://github.com/cloudflare/vinext/commit/4be67bb387a2135fa9f77edde966effc3869e98d) fix: make chat notification non-fatal and add charset to content-type ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish.yml` (+3 -2) </details> ### 📄 Description ## Summary The Google Chat notification step failed on the first publish run ([logs](https://github.com/cloudflare/vinext/actions/runs/22404152202/job/64859480279#step:10:13)), which marked the entire workflow as failed even though the npm publish succeeded. Two fixes: - **`continue-on-error: true`** — a failed notification should never fail the publish workflow - **`Content-Type: application/json; charset=UTF-8`** — Google Chat API requires the charset; this is likely why the request was rejected (HTTP 4xx) - **`-fSs -o /dev/null -w "HTTP %{http_code}"`** — shows the HTTP status code in logs on failure instead of silently swallowing errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>