[PR #67] [MERGED] Skip deploy previews for fork PRs #285

Closed
opened 2026-05-06 12:38:58 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/67
Author: @southpolesteve
Created: 2/25/2026
Status: Merged
Merged: 2/25/2026
Merged by: @southpolesteve

Base: mainHead: fix/skip-deploy-for-forks


📝 Commits (1)

  • d951af6 Skip deploy previews for fork PRs that lack Cloudflare secrets

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 .github/workflows/deploy-examples.yml (+3 -3)

📄 Description

Summary

  • Fork PRs don't have access to repository secrets (CLOUDFLARE_API_TOKEN, CLOUDFLARE_ACCOUNT_ID), causing all deploy jobs to fail with red X's whenever an external contributor opens a PR
  • Adds github.event.pull_request.head.repo.full_name == github.repository condition to the deploy preview step, smoke test preview step, and comment job
  • Example builds still run for fork PRs (validates the code compiles), only the deploy/smoke-test/comment steps are skipped

This matches the workers-sdk pattern where preview deploys are only run for internal branches.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/67 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `fix/skip-deploy-for-forks` --- ### 📝 Commits (1) - [`d951af6`](https://github.com/cloudflare/vinext/commit/d951af6a9bc4e890d8a74fc668b4d588ba923257) Skip deploy previews for fork PRs that lack Cloudflare secrets ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/deploy-examples.yml` (+3 -3) </details> ### 📄 Description ## Summary - Fork PRs don't have access to repository secrets (`CLOUDFLARE_API_TOKEN`, `CLOUDFLARE_ACCOUNT_ID`), causing all deploy jobs to fail with red X's whenever an external contributor opens a PR - Adds `github.event.pull_request.head.repo.full_name == github.repository` condition to the deploy preview step, smoke test preview step, and comment job - Example builds still run for fork PRs (validates the code compiles), only the deploy/smoke-test/comment steps are skipped This matches the workers-sdk pattern where preview deploys are only run for internal branches. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:38:58 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#285
No description provided.