[PR #74] [CLOSED] fix(app-router): decode metadata helper import path on Windows #289

New issue

Closed

opened 2026-05-06 12:38:59 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:38:59 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/74
Author: @msaad53407
Created: 2/25/2026
Status: ❌ Closed

Base: main ← Head: fix/windows-metadata-path-decode

📝 Commits (1)

889c652 fix(app-router): decode metadata helper import path on Windows

📊 Changes

2 files changed (+22 additions, -1 deletions)

View changed files

📝 packages/vinext/src/server/app-dev-server.ts (+1 -1)
📝 tests/app-router.test.ts (+21 -0)

📄 Description

Summary

fix App Router dev RSC entry generation to decode the metadata-routes.js file URL pathname before embedding it as an import path
prevents %20-encoded Windows paths (directories with spaces) from being treated as literal filesystem segments
add a regression test in ests/app-router.test.ts to ensure generated metadata helper import paths do not contain encoded %20`n

Validation

pnpm test -- tests/app-router.test.ts (pass in this branch)
full checks (pnpm run lint, pnpm run typecheck, pnpm test, pnpm run test:e2e) were run by the local contributor before opening this PR

Context

This addresses a Windows-only dev server failure where metadata helper imports could resolve to encoded paths and trigger a 500 when project directories include spaces.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/74 **Author:** [@msaad53407](https://github.com/msaad53407) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/windows-metadata-path-decode` --- ### 📝 Commits (1) - [`889c652`](https://github.com/cloudflare/vinext/commit/889c6526a78c44308024427727cfb0552c8bfea9) fix(app-router): decode metadata helper import path on Windows ### 📊 Changes **2 files changed** (+22 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-dev-server.ts` (+1 -1) 📝 `tests/app-router.test.ts` (+21 -0) </details> ### 📄 Description ## Summary - fix App Router dev RSC entry generation to decode the metadata-routes.js file URL pathname before embedding it as an import path - prevents %20-encoded Windows paths (directories with spaces) from being treated as literal filesystem segments - add a regression test in ests/app-router.test.ts to ensure generated metadata helper import paths do not contain encoded %20`n ## Validation - pnpm test -- tests/app-router.test.ts (pass in this branch) - full checks (pnpm run lint, pnpm run typecheck, pnpm test, pnpm run test:e2e) were run by the local contributor before opening this PR ## Context This addresses a Windows-only dev server failure where metadata helper imports could resolve to encoded paths and trigger a 500 when project directories include spaces. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>