[GH-ISSUE #135] Track jsx-runtime compatibility for remaining shim .tsx modules #29

Closed
opened 2026-05-06 12:36:39 +02:00 by BreizhHardware · 1 comment

Originally created by @liuxiaopai-ai on GitHub (Feb 26, 2026).
Original GitHub issue: https://github.com/cloudflare/vinext/issues/135

Following review feedback on #45: while error-boundary.tsx is fixed, several other shim modules still rely on JSX transform assumptions and may hit the same react/jsx-runtime named-export mismatch in specific packaging setups.

Candidate files called out in review:

  • packages/vinext/src/shims/link.tsx
  • packages/vinext/src/shims/metadata.tsx
  • packages/vinext/src/shims/legacy-image.tsx
  • packages/vinext/src/shims/form.tsx
  • packages/vinext/src/shims/document.tsx
  • packages/vinext/src/shims/image.tsx

Proposed follow-up:

  1. Decide whether to normalize these shims to React.createElement style, or
  2. Fix at plugin level (@vitejs/plugin-rsc) so JSX transform remains robust regardless of user tsconfig/package interop.

I can follow up with a focused PR once direction is confirmed.

Originally created by @liuxiaopai-ai on GitHub (Feb 26, 2026). Original GitHub issue: https://github.com/cloudflare/vinext/issues/135 Following review feedback on #45: while `error-boundary.tsx` is fixed, several other shim modules still rely on JSX transform assumptions and may hit the same `react/jsx-runtime` named-export mismatch in specific packaging setups. Candidate files called out in review: - `packages/vinext/src/shims/link.tsx` - `packages/vinext/src/shims/metadata.tsx` - `packages/vinext/src/shims/legacy-image.tsx` - `packages/vinext/src/shims/form.tsx` - `packages/vinext/src/shims/document.tsx` - `packages/vinext/src/shims/image.tsx` Proposed follow-up: 1. Decide whether to normalize these shims to `React.createElement` style, or 2. Fix at plugin level (`@vitejs/plugin-rsc`) so JSX transform remains robust regardless of user tsconfig/package interop. I can follow up with a focused PR once direction is confirmed.
Author
Owner

@liuxiaopai-ai commented on GitHub (Feb 26, 2026):

Opened follow-up implementation PR: #136

<!-- gh-comment-id:3968550874 --> @liuxiaopai-ai commented on GitHub (Feb 26, 2026): Opened follow-up implementation PR: #136
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#29
No description provided.