[PR #81] [CLOSED] fix(deploy): run wrangler via node instead of shell wrapper #291

New issue

Closed

opened 2026-05-06 12:39:01 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:01 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/81
Author: @gembleman
Created: 2/25/2026
Status: ❌ Closed

Base: main ← Head: fix/deploy-windows-wrangler

📝 Commits (3)

435a8c1 fix(deploy): run wrangler via node instead of shell wrapper
6f06e56 fix(deploy): add exit code check after spawnSync for wrangler
923d48e fix(deploy): remove unused execFileSync and ExecSyncOptions imports

📊 Changes

1 file changed (+16 additions, -11 deletions)

View changed files

📝 packages/vinext/src/deploy.ts (+16 -11)

📄 Description

.bin/wrangler is a platform-specific shell script that fails on Windows (ENOENT) and triggers DEP0190 deprecation warnings when invoked with execFileSync + shell option. Replace with spawnSync on the wrangler JS entry directly via process.execPath for cross-platform compatibility.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/81 **Author:** [@gembleman](https://github.com/gembleman) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/deploy-windows-wrangler` --- ### 📝 Commits (3) - [`435a8c1`](https://github.com/cloudflare/vinext/commit/435a8c118bcf4e163a27a5f131acc76fbb94558d) fix(deploy): run wrangler via node instead of shell wrapper - [`6f06e56`](https://github.com/cloudflare/vinext/commit/6f06e560779800d3680abd1139622f7df51d0caa) fix(deploy): add exit code check after spawnSync for wrangler - [`923d48e`](https://github.com/cloudflare/vinext/commit/923d48e2449f516c70871beabbd3f336e6cbbae1) fix(deploy): remove unused execFileSync and ExecSyncOptions imports ### 📊 Changes **1 file changed** (+16 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/deploy.ts` (+16 -11) </details> ### 📄 Description .bin/wrangler is a platform-specific shell script that fails on Windows (ENOENT) and triggers DEP0190 deprecation warnings when invoked with execFileSync + shell option. Replace with spawnSync on the wrangler JS entry directly via process.execPath for cross-platform compatibility. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>