[PR #117] [CLOSED] fix(tests): centralize and fix shim type definitions #323

New issue

Closed

opened 2026-05-06 12:39:12 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:12 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/117
Author: @SXP-Simon
Created: 2/26/2026
Status: ❌ Closed

Base: main ← Head: chore/shared-shims

📝 Commits (2)

308c5b5 fix(tests): centralize and fix shim type definitions
7a75866 Merge branch 'main' into chore/shared-shims

📊 Changes

5 files changed (+229 additions, -225 deletions)

View changed files

➖ tests/fixtures/app-basic/next-shims.d.ts (+0 -36)
📝 tests/fixtures/app-basic/tsconfig.json (+14 -4)
➕ tests/fixtures/next-shims.d.ts (+205 -0)
➖ tests/fixtures/pages-basic/next-shims.d.ts (+0 -182)
📝 tests/fixtures/pages-basic/tsconfig.json (+10 -3)

📄 Description

Fix missing 'next/server' typings in app-basic fixture
Enhance NextResponse.next/rewrite types to support request overrides
Extract all common declare module shims into tests/fixtures/shared-shims.d.ts
Update tsconfig.json in basic fixtures to include shared shims
Remove redundant and inconsistent next-shims.d.ts from fixtures

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/117 **Author:** [@SXP-Simon](https://github.com/SXP-Simon) **Created:** 2/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chore/shared-shims` --- ### 📝 Commits (2) - [`308c5b5`](https://github.com/cloudflare/vinext/commit/308c5b56e2c4a30ed762b965f03d58b7c442b61e) fix(tests): centralize and fix shim type definitions - [`7a75866`](https://github.com/cloudflare/vinext/commit/7a75866d2190bf98f7c6afa788eb7f3fcd6486c2) Merge branch 'main' into chore/shared-shims ### 📊 Changes **5 files changed** (+229 additions, -225 deletions) <details> <summary>View changed files</summary> ➖ `tests/fixtures/app-basic/next-shims.d.ts` (+0 -36) 📝 `tests/fixtures/app-basic/tsconfig.json` (+14 -4) ➕ `tests/fixtures/next-shims.d.ts` (+205 -0) ➖ `tests/fixtures/pages-basic/next-shims.d.ts` (+0 -182) 📝 `tests/fixtures/pages-basic/tsconfig.json` (+10 -3) </details> ### 📄 Description - Fix missing 'next/server' typings in app-basic fixture - Enhance NextResponse.next/rewrite types to support request overrides - Extract all common declare module shims into tests/fixtures/shared-shims.d.ts - Update tsconfig.json in basic fixtures to include shared shims - Remove redundant and inconsistent next-shims.d.ts from fixtures --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>