[PR #133] [MERGED] fix: log errors from failed error reporting calls #338

New issue

Closed

opened 2026-05-06 12:39:17 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:17 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/133
Author: @heyitsmohdd
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/27/2026
Merged by: @FredKSchott

Base: main ← Head: fix/silent-error-handling

📝 Commits (2)

884310a fix: log errors from failed error reporting calls
fa24a99 revert: keep silent .catch for loading boundary pre-render test

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 packages/vinext/src/server/app-dev-server.ts (+6 -2)

📄 Description

What This PR Does

Found a bug where errors were being silently swallowed. If something went wrong while trying to report an error, that error just disappeared into the void. Not great for debugging.

Fixed 3 spots in the app dev server:

Server actions - when they fail and we try to report the error, we now log it if that reporting itself fails
Route handlers - same thing
Async components with loading boundaries - these are handled correctly but now we also log errors in development so you can see what's happening

No breaking changes. Just adds some error logging so we can actually debug when things go wrong.

Tests: All pass - 1400+ tests, typecheck, lint all good.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/133 **Author:** [@heyitsmohdd](https://github.com/heyitsmohdd) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/27/2026 **Merged by:** [@FredKSchott](https://github.com/FredKSchott) **Base:** `main` ← **Head:** `fix/silent-error-handling` --- ### 📝 Commits (2) - [`884310a`](https://github.com/cloudflare/vinext/commit/884310a5556e6169416268111a8300f8acc85c6b) fix: log errors from failed error reporting calls - [`fa24a99`](https://github.com/cloudflare/vinext/commit/fa24a99a81d4e0e4cfa4cf5f2ff31835d3ca9e5f) revert: keep silent .catch for loading boundary pre-render test ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-dev-server.ts` (+6 -2) </details> ### 📄 Description What This PR Does Found a bug where errors were being silently swallowed. If something went wrong while trying to report an error, that error just disappeared into the void. Not great for debugging. Fixed 3 spots in the app dev server: 1. Server actions - when they fail and we try to report the error, we now log it if that reporting itself fails 2. Route handlers - same thing 3. Async components with loading boundaries - these are handled correctly but now we also log errors in development so you can see what's happening No breaking changes. Just adds some error logging so we can actually debug when things go wrong. Tests: All pass - 1400+ tests, typecheck, lint all good. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>