[PR #206] [MERGED] test: add Pages Router has/missing header condition coverage #385

New issue

Closed

opened 2026-05-06 12:39:32 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:32 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/206
Author: @southpolesteve
Created: 2/28/2026
Status: ✅ Merged
Merged: 2/28/2026
Merged by: @southpolesteve

Base: main ← Head: test/pages-router-has-missing-coverage

📝 Commits (1)

5478a30 test: add Pages Router has/missing header condition coverage

📊 Changes

2 files changed (+42 additions, -0 deletions)

View changed files

📝 tests/fixtures/pages-basic/next.config.mjs (+12 -0)
📝 tests/pages-router.test.ts (+30 -0)

📄 Description

Summary

Adds integration tests for has/missing conditions on next.config.js headers in the Pages Router (dev + production servers)
Adds corresponding fixture config in pages-basic/next.config.mjs

The implementation was merged in #48 but lacked Pages Router-specific test coverage. These tests were ported from #47 by @ibruno.

Closes #47

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/206 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 2/28/2026 **Status:** ✅ Merged **Merged:** 2/28/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `test/pages-router-has-missing-coverage` --- ### 📝 Commits (1) - [`5478a30`](https://github.com/cloudflare/vinext/commit/5478a30d10a116ec26c412a88fcfaaa77019c2ff) test: add Pages Router has/missing header condition coverage ### 📊 Changes **2 files changed** (+42 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tests/fixtures/pages-basic/next.config.mjs` (+12 -0) 📝 `tests/pages-router.test.ts` (+30 -0) </details> ### 📄 Description ## Summary - Adds integration tests for `has`/`missing` conditions on `next.config.js` headers in the Pages Router (dev + production servers) - Adds corresponding fixture config in `pages-basic/next.config.mjs` The implementation was merged in #48 but lacked Pages Router-specific test coverage. These tests were ported from #47 by @ibruno. Closes #47 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>