[PR #209] [MERGED] fix: use exact heading locator in next/dynamic E2E to fix flaky test #386

New issue

Closed

opened 2026-05-06 12:39:32 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:32 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/209
Author: @southpolesteve
Created: 3/1/2026
Status: ✅ Merged
Merged: 3/1/2026
Merged by: @southpolesteve

Base: main ← Head: fix/flaky-dynamic-e2e-locator

📝 Commits (1)

3bee564 fix: use exact heading locator in next/dynamic E2E to fix flaky test

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 tests/e2e/pages-router/head-and-dynamic.spec.ts (+6 -2)

📄 Description

Summary

Replaces ambiguous text=Heavy Component locator with getByRole("heading", { level: 2, name: "Heavy Component" }) in the pages-router next/dynamic E2E tests
Prevents false matches when the text appears in multiple elements on the page

Extracted from #134 by @erayack.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/209 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/1/2026 **Status:** ✅ Merged **Merged:** 3/1/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `fix/flaky-dynamic-e2e-locator` --- ### 📝 Commits (1) - [`3bee564`](https://github.com/cloudflare/vinext/commit/3bee564af252e4e434faf2e8cf74a28755c1ed22) fix: use exact heading locator in next/dynamic E2E to fix flaky test ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/e2e/pages-router/head-and-dynamic.spec.ts` (+6 -2) </details> ### 📄 Description ## Summary - Replaces ambiguous `text=Heavy Component` locator with `getByRole("heading", { level: 2, name: "Heavy Component" })` in the pages-router `next/dynamic` E2E tests - Prevents false matches when the text appears in multiple elements on the page Extracted from #134 by @erayack. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>