[PR #210] [MERGED] test: add ShadCN/Radix UI ecosystem coverage #389

New issue

Closed

opened 2026-05-06 12:39:33 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:33 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/210
Author: @southpolesteve
Created: 3/1/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @southpolesteve

Base: main ← Head: test/shadcn-ecosystem-coverage

📝 Commits (3)

d951af6 Skip deploy previews for fork PRs that lack Cloudflare secrets
1e46ec7 test: add ShadCN/Radix UI ecosystem coverage
ebc5ea5 Merge remote-tracking branch 'origin/main' into resolve-conflicts

📊 Changes

12 files changed (+1148 additions, -0 deletions)

View changed files

📝 pnpm-lock.yaml (+715 -0)
📝 tests/ecosystem.test.ts (+54 -0)
➕ tests/fixtures/ecosystem/shadcn/app/dialog-demo.tsx (+31 -0)
➕ tests/fixtures/ecosystem/shadcn/app/dropdown-demo.tsx (+39 -0)
➕ tests/fixtures/ecosystem/shadcn/app/layout.tsx (+15 -0)
➕ tests/fixtures/ecosystem/shadcn/app/page.tsx (+42 -0)
➕ tests/fixtures/ecosystem/shadcn/components/ui/button.tsx (+52 -0)
➕ tests/fixtures/ecosystem/shadcn/components/ui/dialog.tsx (+89 -0)
➕ tests/fixtures/ecosystem/shadcn/components/ui/dropdown-menu.tsx (+78 -0)
➕ tests/fixtures/ecosystem/shadcn/lib/utils.ts (+6 -0)
➕ tests/fixtures/ecosystem/shadcn/package.json (+21 -0)
➕ tests/fixtures/ecosystem/shadcn/vite.config.ts (+6 -0)

📄 Description

Summary

Adds ecosystem integration tests for ShadCN components backed by Radix UI primitives, ensuring we don't regress on this popular library combination
Tests Button (server component with @radix-ui/react-slot), Dialog (@radix-ui/react-dialog), and DropdownMenu (@radix-ui/react-dropdown-menu)
Verifies that @radix-ui/react-slot works correctly in the RSC environment without "use client", while context-heavy packages like @radix-ui/react-dialog are properly proxied via their "use client" directives

Closes #100

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/210 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/1/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `test/shadcn-ecosystem-coverage` --- ### 📝 Commits (3) - [`d951af6`](https://github.com/cloudflare/vinext/commit/d951af6a9bc4e890d8a74fc668b4d588ba923257) Skip deploy previews for fork PRs that lack Cloudflare secrets - [`1e46ec7`](https://github.com/cloudflare/vinext/commit/1e46ec74042b17c400dc1f1841d605cbbfd11a8d) test: add ShadCN/Radix UI ecosystem coverage - [`ebc5ea5`](https://github.com/cloudflare/vinext/commit/ebc5ea5f503b3f81858bc418f0611933065a409c) Merge remote-tracking branch 'origin/main' into resolve-conflicts ### 📊 Changes **12 files changed** (+1148 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pnpm-lock.yaml` (+715 -0) 📝 `tests/ecosystem.test.ts` (+54 -0) ➕ `tests/fixtures/ecosystem/shadcn/app/dialog-demo.tsx` (+31 -0) ➕ `tests/fixtures/ecosystem/shadcn/app/dropdown-demo.tsx` (+39 -0) ➕ `tests/fixtures/ecosystem/shadcn/app/layout.tsx` (+15 -0) ➕ `tests/fixtures/ecosystem/shadcn/app/page.tsx` (+42 -0) ➕ `tests/fixtures/ecosystem/shadcn/components/ui/button.tsx` (+52 -0) ➕ `tests/fixtures/ecosystem/shadcn/components/ui/dialog.tsx` (+89 -0) ➕ `tests/fixtures/ecosystem/shadcn/components/ui/dropdown-menu.tsx` (+78 -0) ➕ `tests/fixtures/ecosystem/shadcn/lib/utils.ts` (+6 -0) ➕ `tests/fixtures/ecosystem/shadcn/package.json` (+21 -0) ➕ `tests/fixtures/ecosystem/shadcn/vite.config.ts` (+6 -0) </details> ### 📄 Description ## Summary - Adds ecosystem integration tests for ShadCN components backed by Radix UI primitives, ensuring we don't regress on this popular library combination - Tests Button (server component with `@radix-ui/react-slot`), Dialog (`@radix-ui/react-dialog`), and DropdownMenu (`@radix-ui/react-dropdown-menu`) - Verifies that `@radix-ui/react-slot` works correctly in the RSC environment without `"use client"`, while context-heavy packages like `@radix-ui/react-dialog` are properly proxied via their `"use client"` directives Closes #100 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>