[PR #218] [CLOSED] fix: include package modules in commonjs transform #397

New issue

Closed

opened 2026-05-06 12:39:37 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:37 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/218
Author: @zebp
Created: 3/1/2026
Status: ❌ Closed

Base: main ← Head: zeb/cjs-dependencies

📝 Commits (1)

f895eb4 fix: include package modules in commonjs transform

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 packages/vinext/src/index.ts (+10 -1)

📄 Description

Previously we only transformed CJS modules if they were part of the part of the project and not if they were in the project's dependencies. Now we will apply CJS to ESM transformations if the vite module id can be resolved to a node module.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/218 **Author:** [@zebp](https://github.com/zebp) **Created:** 3/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `zeb/cjs-dependencies` --- ### 📝 Commits (1) - [`f895eb4`](https://github.com/cloudflare/vinext/commit/f895eb4ead65412cb07c7a5ea58a418c568c9f55) fix: include package modules in commonjs transform ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/index.ts` (+10 -1) </details> ### 📄 Description Previously we only transformed CJS modules if they were part of the part of the project and not if they were in the project's dependencies. Now we will apply CJS to ESM transformations if the vite module id can be resolved to a node module. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>