[PR #221] [CLOSED] fix: add directory to wrangler assets config for static export #399

Closed
opened 2026-05-06 12:39:37 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/221
Author: @arifpro
Created: 3/2/2026
Status: Closed

Base: mainHead: fix/219-wrangler-assets-directory


📝 Commits (6)

  • 814b37a fix: add directory to wrangler assets config for static export
  • dc26467 Merge remote-tracking branch 'origin/main' into fix/219-wrangler-assets-directory
  • 9f4d552 fix: address review comments on static export wrangler config
  • c6fcf23 test: update and expand deploy tests for static export
  • 2a4ee2e fix: address bonk review comments on static export deploy
  • de1051f fix: keep compatibility_flags and images in wrangler config for static export

📊 Changes

2 files changed (+336 additions, -20 deletions)

View changed files

📝 packages/vinext/src/deploy.ts (+181 -19)
📝 tests/deploy.test.ts (+155 -1)

📄 Description

When using output: 'export' in next.config.ts, wrangler 4.69.0 requires
the assets config to include a directory property. This fix:

  • Detects output mode from next.config during deploy
  • Adds directory: 'export' to wrangler assets config for static export
  • Skips images binding for static export (not needed since images are
    pre-optimized at build time)

Fixes #219


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/221 **Author:** [@arifpro](https://github.com/arifpro) **Created:** 3/2/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/219-wrangler-assets-directory` --- ### 📝 Commits (6) - [`814b37a`](https://github.com/cloudflare/vinext/commit/814b37a4897afbbcb80647a57ef802370ca2b987) fix: add directory to wrangler assets config for static export - [`dc26467`](https://github.com/cloudflare/vinext/commit/dc2646784706f4a4ccf004047b857c75adbc9864) Merge remote-tracking branch 'origin/main' into fix/219-wrangler-assets-directory - [`9f4d552`](https://github.com/cloudflare/vinext/commit/9f4d552b95a7ae0872c9cb98f2bbddbfff451fb1) fix: address review comments on static export wrangler config - [`c6fcf23`](https://github.com/cloudflare/vinext/commit/c6fcf23ce20766160a22f40be35d73dd422511cd) test: update and expand deploy tests for static export - [`2a4ee2e`](https://github.com/cloudflare/vinext/commit/2a4ee2e01231968e8fdc2a5799216450bb59712b) fix: address bonk review comments on static export deploy - [`de1051f`](https://github.com/cloudflare/vinext/commit/de1051fde96b6eacbfb0460985e3a6418d7dee88) fix: keep compatibility_flags and images in wrangler config for static export ### 📊 Changes **2 files changed** (+336 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/deploy.ts` (+181 -19) 📝 `tests/deploy.test.ts` (+155 -1) </details> ### 📄 Description When using output: 'export' in next.config.ts, wrangler 4.69.0 requires the assets config to include a directory property. This fix: - Detects output mode from next.config during deploy - Adds directory: 'export' to wrangler assets config for static export - Skips images binding for static export (not needed since images are pre-optimized at build time) Fixes #219 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:39:37 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#399
No description provided.