[PR #300] [MERGED] chore: improvements to various ci workflows #458

New issue

Closed

opened 2026-05-06 12:39:53 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:53 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/300
Author: @james-elicx
Created: 3/6/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @james-elicx

Base: main ← Head: james/improve-workflows

📝 Commits (2)

b0f60a9 chore: improvements to various ci workflows
b05c72b fix(ci): gate publish and preview-release on repository_owner == cloudflare

📊 Changes

6 files changed (+10 additions, -6 deletions)

View changed files

📝 .github/workflows/benchmarks.yml (+3 -3)
📝 .github/workflows/ci.yml (+1 -1)
📝 .github/workflows/deploy-preview-command.yml (+2 -1)
📝 .github/workflows/preview-release.yml (+2 -0)
📝 .github/workflows/publish.yml (+1 -0)
📝 .github/workflows/tip.yml (+1 -1)

📄 Description

Fix tip.yml spurious runs - invalid ${{ }} wrapper on secrets if: check caused GitHub to fire the workflow on every push
Fix benchmarks.yml broken install - cd ../vinext in a run: block resolves from repo root, not previous directory; use npm install --prefix instead
Gate publish and preview-release on repository_owner == 'cloudflare'
Fix ci.yml concurrency group to include event_name, preventing push and PR runs from cancelling each other
Fix deploy-preview-command.yml: add --frozen-lockfile; only post preview URLs when deploy succeeds

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/300 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `james/improve-workflows` --- ### 📝 Commits (2) - [`b0f60a9`](https://github.com/cloudflare/vinext/commit/b0f60a98427cd2de11fe1a8aeca38f2a7b5541dd) chore: improvements to various ci workflows - [`b05c72b`](https://github.com/cloudflare/vinext/commit/b05c72bc7de3d00045cae81ee7869a5434496d48) fix(ci): gate publish and preview-release on repository_owner == cloudflare ### 📊 Changes **6 files changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/benchmarks.yml` (+3 -3) 📝 `.github/workflows/ci.yml` (+1 -1) 📝 `.github/workflows/deploy-preview-command.yml` (+2 -1) 📝 `.github/workflows/preview-release.yml` (+2 -0) 📝 `.github/workflows/publish.yml` (+1 -0) 📝 `.github/workflows/tip.yml` (+1 -1) </details> ### 📄 Description - Fix `tip.yml` spurious runs - invalid `${{ }}` wrapper on secrets `if:` check caused GitHub to fire the workflow on every push - Fix benchmarks.yml broken install - `cd ../vinext` in a `run:` block resolves from repo root, not previous directory; use `npm install --prefix` instead - Gate publish and preview-release on `repository_owner == 'cloudflare'` - Fix `ci.yml` concurrency group to include `event_name`, preventing push and PR runs from cancelling each other - Fix `deploy-preview-command.yml`: add `--frozen-lockfile`; only post preview URLs when deploy succeeds --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>