[PR #316] [MERGED] test: use metadata API in app-basic root layout #472

New issue

Closed

opened 2026-05-06 13:08:16 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:08:16 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/316
Author: @NathanDrake2406
Created: 3/7/2026
Status: ✅ Merged
Merged: 3/7/2026
Merged by: @james-elicx

Base: main ← Head: fix/metadata-fixture-title-duplication

📝 Commits (1)

6d84ae5 test: use metadata API in app-basic root layout

📊 Changes

2 files changed (+11 additions, -19 deletions)

View changed files

📝 tests/fixtures/app-basic/app/layout.tsx (+6 -5)
📝 tests/nextjs-compat/metadata-suspense.test.ts (+5 -14)

📄 Description

Summary

move the shared app-basic root title from manual <head> markup to the Metadata API
enable the metadata-suspense duplicate-title regression test
update the test comment to describe the real failure mode

Why

The duplicate <title> was coming from the shared test fixture root layout hardcoding <title>App Basic</title>, not from Suspense-specific metadata streaming.

Testing

pnpm test tests/nextjs-compat/metadata-suspense.test.ts tests/nextjs-compat/metadata.test.ts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/316 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 3/7/2026 **Status:** ✅ Merged **Merged:** 3/7/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/metadata-fixture-title-duplication` --- ### 📝 Commits (1) - [`6d84ae5`](https://github.com/cloudflare/vinext/commit/6d84ae56c407fbf2c3f3dddde8ee274a491daf03) test: use metadata API in app-basic root layout ### 📊 Changes **2 files changed** (+11 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `tests/fixtures/app-basic/app/layout.tsx` (+6 -5) 📝 `tests/nextjs-compat/metadata-suspense.test.ts` (+5 -14) </details> ### 📄 Description ## Summary - move the shared app-basic root title from manual `<head>` markup to the Metadata API - enable the metadata-suspense duplicate-title regression test - update the test comment to describe the real failure mode ## Why The duplicate `<title>` was coming from the shared test fixture root layout hardcoding `<title>App Basic</title>`, not from Suspense-specific metadata streaming. ## Testing - `pnpm test tests/nextjs-compat/metadata-suspense.test.ts tests/nextjs-compat/metadata.test.ts` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>