[PR #350] [MERGED] test: add a fixme for middleware invocation count tracking #499

Closed
opened 2026-05-06 13:08:24 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/350
Author: @james-elicx
Created: 3/8/2026
Status: Merged
Merged: 3/8/2026
Merged by: @james-elicx

Base: mainHead: j-branch-6


📝 Commits (2)

  • 600806d test: add a fixme for middleware invocation count tracking
  • c3b6538 test: clarify why registerCalled uses ESM live binding not globalThis

📊 Changes

4 files changed (+156 additions, -45 deletions)

View changed files

📝 tests/e2e/app-router/middleware.spec.ts (+40 -0)
📝 tests/fixtures/app-basic/app/api/instrumentation-test/route.ts (+14 -9)
📝 tests/fixtures/app-basic/instrumentation-state.ts (+95 -36)
📝 tests/fixtures/app-basic/middleware.ts (+7 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/350 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 3/8/2026 **Status:** ✅ Merged **Merged:** 3/8/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `j-branch-6` --- ### 📝 Commits (2) - [`600806d`](https://github.com/cloudflare/vinext/commit/600806de2be25ee166beb0bd7fbac4cfd57ae5e5) test: add a fixme for middleware invocation count tracking - [`c3b6538`](https://github.com/cloudflare/vinext/commit/c3b6538ff421abb11459cf9c1d1ad1df7ab88816) test: clarify why registerCalled uses ESM live binding not globalThis ### 📊 Changes **4 files changed** (+156 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `tests/e2e/app-router/middleware.spec.ts` (+40 -0) 📝 `tests/fixtures/app-basic/app/api/instrumentation-test/route.ts` (+14 -9) 📝 `tests/fixtures/app-basic/instrumentation-state.ts` (+95 -36) 📝 `tests/fixtures/app-basic/middleware.ts` (+7 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 13:08:24 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#499
No description provided.