[PR #379] [MERGED] refactor: delete app-dev-server.ts, point all callers at entries/ directly (#253 batch 3) #525

New issue

Closed

opened 2026-05-06 13:08:32 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:08:32 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/379
Author: @james-elicx
Created: 3/9/2026
Status: ✅ Merged
Merged: 3/9/2026
Merged by: @james-elicx

Base: main ← Head: refactor/remove-app-dev-server

📝 Commits (2)

27878e4 refactor: delete app-dev-server.ts and update all references to entries/ directly
3e83bd5 docs: update app-dev-server.ts references in markdown files to entries/

📊 Changes

21 files changed (+54 additions, -64 deletions)

View changed files

📝 .opencode/agents/reviewer.md (+1 -1)
📝 .opencode/agents/viguy.md (+4 -4)
📝 .opencode/commands/fix-issue.md (+1 -1)
📝 .opencode/commands/review-pr.md (+1 -1)
📝 AGENTS.md (+4 -4)
📝 README.md (+6 -1)
📝 examples/app-router-cloudflare/instrumentation-state.ts (+1 -1)
📝 examples/app-router-cloudflare/instrumentation.ts (+1 -1)
📝 packages/vinext/src/entries/app-rsc-entry.ts (+1 -1)
📝 packages/vinext/src/index.ts (+3 -5)
➖ packages/vinext/src/server/app-dev-server.ts (+0 -11)
📝 packages/vinext/src/server/instrumentation.ts (+1 -1)
📝 packages/vinext/src/server/middleware-codegen.ts (+1 -1)
📝 packages/vinext/src/server/request-pipeline.ts (+2 -2)
📝 packages/vinext/src/shims/metadata.tsx (+1 -1)
📝 tests/app-router.test.ts (+6 -6)
📝 tests/entry-templates.test.ts (+4 -6)
📝 tests/nextjs-compat/TRACKING.md (+10 -10)
📝 tests/nextjs-compat/rsc-context-lazy-stream.test.ts (+1 -1)
📝 tests/rsc-streaming.test.ts (+2 -2)

...and 1 more files

📄 Description

Summary

Follows #377 and #378. Now that all generators live in entries/, the server/app-dev-server.ts shim (which was just three re-exports) can be deleted.

Changes:

Delete packages/vinext/src/server/app-dev-server.ts
Update every import/dynamic-import site to point straight at the individual entry modules:
- entries/app-rsc-entry.ts — generateRscEntry, AppRouterConfig
- entries/app-ssr-entry.ts — generateSsrEntry
- entries/app-browser-entry.ts — generateBrowserEntry
Update stale app-dev-server.ts references in comments across source files, tests, and examples

Files updated: index.ts, tests/entry-templates.test.ts, tests/app-router.test.ts, tests/shims.test.ts, plus comments in 6 other files.

Verification

pnpm run lint — 0 warnings, 0 errors
pnpm run typecheck — clean
pnpm test tests/entry-templates.test.ts — 10/10 pass

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/379 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 3/9/2026 **Status:** ✅ Merged **Merged:** 3/9/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `refactor/remove-app-dev-server` --- ### 📝 Commits (2) - [`27878e4`](https://github.com/cloudflare/vinext/commit/27878e4c5bfd3e7d083e7661e8a7f940084a2758) refactor: delete app-dev-server.ts and update all references to entries/ directly - [`3e83bd5`](https://github.com/cloudflare/vinext/commit/3e83bd581d1cff0b53a86ce4e60210175870c1eb) docs: update app-dev-server.ts references in markdown files to entries/ ### 📊 Changes **21 files changed** (+54 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `.opencode/agents/reviewer.md` (+1 -1) 📝 `.opencode/agents/viguy.md` (+4 -4) 📝 `.opencode/commands/fix-issue.md` (+1 -1) 📝 `.opencode/commands/review-pr.md` (+1 -1) 📝 `AGENTS.md` (+4 -4) 📝 `README.md` (+6 -1) 📝 `examples/app-router-cloudflare/instrumentation-state.ts` (+1 -1) 📝 `examples/app-router-cloudflare/instrumentation.ts` (+1 -1) 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+1 -1) 📝 `packages/vinext/src/index.ts` (+3 -5) ➖ `packages/vinext/src/server/app-dev-server.ts` (+0 -11) 📝 `packages/vinext/src/server/instrumentation.ts` (+1 -1) 📝 `packages/vinext/src/server/middleware-codegen.ts` (+1 -1) 📝 `packages/vinext/src/server/request-pipeline.ts` (+2 -2) 📝 `packages/vinext/src/shims/metadata.tsx` (+1 -1) 📝 `tests/app-router.test.ts` (+6 -6) 📝 `tests/entry-templates.test.ts` (+4 -6) 📝 `tests/nextjs-compat/TRACKING.md` (+10 -10) 📝 `tests/nextjs-compat/rsc-context-lazy-stream.test.ts` (+1 -1) 📝 `tests/rsc-streaming.test.ts` (+2 -2) _...and 1 more files_ </details> ### 📄 Description ## Summary Follows #377 and #378. Now that all generators live in `entries/`, the `server/app-dev-server.ts` shim (which was just three re-exports) can be deleted. **Changes:** - Delete `packages/vinext/src/server/app-dev-server.ts` - Update every import/dynamic-import site to point straight at the individual entry modules: - `entries/app-rsc-entry.ts` — `generateRscEntry`, `AppRouterConfig` - `entries/app-ssr-entry.ts` — `generateSsrEntry` - `entries/app-browser-entry.ts` — `generateBrowserEntry` - Update stale `app-dev-server.ts` references in comments across source files, tests, and examples **Files updated:** `index.ts`, `tests/entry-templates.test.ts`, `tests/app-router.test.ts`, `tests/shims.test.ts`, plus comments in 6 other files. ## Verification - `pnpm run lint` — 0 warnings, 0 errors - `pnpm run typecheck` — clean - `pnpm test tests/entry-templates.test.ts` — 10/10 pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>