[PR #452] [MERGED] feat: metadata parity for appLinks, iTunes, Twitter player/app cards #581

New issue

Closed

opened 2026-05-06 13:08:54 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:08:54 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/452
Author: @NathanDrake2406
Created: 3/11/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @james-elicx

Base: main ← Head: feat/metadata-applinks-itunes-twitter-cards

📝 Commits (5)

cd7dd95 feat: add metadata support for appLinks, iTunes, and Twitter player/app cards
d9117a3 chore: format metadata files
05f74c1 fix: resolve twitter player/app and appLinks URLs against metadataBase
8d01798 fix: un-nest twitter app card name/url checks to match Next.js behavior
14fdf34 Update packages/vinext/src/shims/metadata.tsx

📊 Changes

6 files changed (+294 additions, -9 deletions)

View changed files

📝 packages/vinext/src/shims/metadata.tsx (+153 -0)
➕ tests/fixtures/app-basic/app/nextjs-compat/metadata-applinks/page.tsx (+24 -0)
➕ tests/fixtures/app-basic/app/nextjs-compat/metadata-itunes/page.tsx (+12 -0)
➕ tests/fixtures/app-basic/app/nextjs-compat/metadata-twitter-app/page.tsx (+27 -0)
➕ tests/fixtures/app-basic/app/nextjs-compat/metadata-twitter-player/page.tsx (+20 -0)
📝 tests/nextjs-compat/metadata.test.ts (+58 -9)

📄 Description

Summary

Add appLinks metadata support — renders al:* property tags for iOS, Android, Windows, and web platforms
Add itunes metadata support — renders apple-itunes-app meta tag with app-id and app-argument
Add Twitter player card support — renders twitter:player, twitter:player:stream, twitter:player:width, twitter:player:height
Add Twitter app card support — renders twitter:app:name/id/url per platform (iphone, ipad, googleplay)

All four were documented as N/A gaps in metadata.test.ts (lines 345, 354, 363). Types match Next.js extra-types.d.ts and twitter-types.d.ts definitions. Rendering matches Next.js generate/opengraph.js and generate/basic.js output.

Test plan

4 new fixture pages (metadata-itunes, metadata-applinks, metadata-twitter-player, metadata-twitter-app)
4 new integration tests asserting exact meta tag output
All 45 metadata tests pass
All 652 shims tests pass
Typecheck clean
CI (Format, Lint, Typecheck, Vitest, Playwright E2E)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/452 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 3/11/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `feat/metadata-applinks-itunes-twitter-cards` --- ### 📝 Commits (5) - [`cd7dd95`](https://github.com/cloudflare/vinext/commit/cd7dd95a8fdc635d5ad307d00f1c6635aeea0858) feat: add metadata support for appLinks, iTunes, and Twitter player/app cards - [`d9117a3`](https://github.com/cloudflare/vinext/commit/d9117a31667eff0d82a4b46e889ecfea23616e8c) chore: format metadata files - [`05f74c1`](https://github.com/cloudflare/vinext/commit/05f74c19fbd3ddfb129b6eb8e0a3a34c0123f1b8) fix: resolve twitter player/app and appLinks URLs against metadataBase - [`8d01798`](https://github.com/cloudflare/vinext/commit/8d01798aa39c1973b8b753c0ee9027a93a1a7ebc) fix: un-nest twitter app card name/url checks to match Next.js behavior - [`14fdf34`](https://github.com/cloudflare/vinext/commit/14fdf3436d52a2169e228a6f9bc5767e0d42210c) Update packages/vinext/src/shims/metadata.tsx ### 📊 Changes **6 files changed** (+294 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/shims/metadata.tsx` (+153 -0) ➕ `tests/fixtures/app-basic/app/nextjs-compat/metadata-applinks/page.tsx` (+24 -0) ➕ `tests/fixtures/app-basic/app/nextjs-compat/metadata-itunes/page.tsx` (+12 -0) ➕ `tests/fixtures/app-basic/app/nextjs-compat/metadata-twitter-app/page.tsx` (+27 -0) ➕ `tests/fixtures/app-basic/app/nextjs-compat/metadata-twitter-player/page.tsx` (+20 -0) 📝 `tests/nextjs-compat/metadata.test.ts` (+58 -9) </details> ### 📄 Description ## Summary - Add `appLinks` metadata support — renders `al:*` property tags for iOS, Android, Windows, and web platforms - Add `itunes` metadata support — renders `apple-itunes-app` meta tag with `app-id` and `app-argument` - Add Twitter player card support — renders `twitter:player`, `twitter:player:stream`, `twitter:player:width`, `twitter:player:height` - Add Twitter app card support — renders `twitter:app:name/id/url` per platform (iphone, ipad, googleplay) All four were documented as N/A gaps in `metadata.test.ts` (lines 345, 354, 363). Types match Next.js `extra-types.d.ts` and `twitter-types.d.ts` definitions. Rendering matches Next.js `generate/opengraph.js` and `generate/basic.js` output. ## Test plan - [x] 4 new fixture pages (`metadata-itunes`, `metadata-applinks`, `metadata-twitter-player`, `metadata-twitter-app`) - [x] 4 new integration tests asserting exact meta tag output - [x] All 45 metadata tests pass - [x] All 652 shims tests pass - [x] Typecheck clean - [x] CI (Format, Lint, Typecheck, Vitest, Playwright E2E) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>