[PR #569] [MERGED] fix: add assets.directory to generated wrangler.jsonc #677

New issue

Closed

opened 2026-05-06 13:09:29 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:29 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/569
Author: @james-elicx
Created: 3/16/2026
Status: ✅ Merged
Merged: 3/16/2026
Merged by: @james-elicx

Base: main ← Head: opencode/jolly-knight

📝 Commits (1)

7c5368d fix: add assets.directory to generated wrangler.jsonc (required by wrangler 4.69+)

📊 Changes

2 files changed (+19 additions, -1 deletions)

View changed files

📝 packages/vinext/src/deploy.ts (+3 -0)
📝 tests/deploy.test.ts (+16 -1)

📄 Description

Summary

Wrangler 4.69+ rejects an assets object that lacks a directory field, causing vinext deploy to fail with: The 'assets' property in your configuration is missing the required 'directory' property
Added directory: "dist/client" to the generated assets block in generateWranglerConfig() — this is always the correct value since @cloudflare/vite-plugin unconditionally writes static assets to dist/client/
Updated the existing test asserting the assets object shape, and added a dedicated test for the directory field

Notes

not_found_handling: "none" is intentional and unchanged — it ensures unmatched requests fall through to the user Worker (enabling SSR) rather than being handled by the asset worker directly

Fixes #219

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/569 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 3/16/2026 **Status:** ✅ Merged **Merged:** 3/16/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `opencode/jolly-knight` --- ### 📝 Commits (1) - [`7c5368d`](https://github.com/cloudflare/vinext/commit/7c5368d86b0881995fd1ba0df7c0c80e7e4d63ee) fix: add assets.directory to generated wrangler.jsonc (required by wrangler 4.69+) ### 📊 Changes **2 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/deploy.ts` (+3 -0) 📝 `tests/deploy.test.ts` (+16 -1) </details> ### 📄 Description ## Summary - Wrangler 4.69+ rejects an `assets` object that lacks a `directory` field, causing `vinext deploy` to fail with: `The 'assets' property in your configuration is missing the required 'directory' property` - Added `directory: "dist/client"` to the generated `assets` block in `generateWranglerConfig()` — this is always the correct value since `@cloudflare/vite-plugin` unconditionally writes static assets to `dist/client/` - Updated the existing test asserting the `assets` object shape, and added a dedicated test for the `directory` field ## Notes - `not_found_handling: "none"` is intentional and unchanged — it ensures unmatched requests fall through to the user Worker (enabling SSR) rather than being handled by the asset worker directly Fixes #219 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>