[PR #627] [MERGED] refactor: extract app page response helpers #725

New issue

Closed

opened 2026-05-06 13:09:48 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:48 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/627
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/21/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-render-policy-runtime

📝 Commits (4)

749734a refactor: extract app page response helpers
77852c5 test: refresh app page response snapshots
2d981f2 docs: clarify app page response miss policy
f32a3bb test: document app page response policy edges

📊 Changes

5 files changed (+1222 additions, -1594 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+106 -226)
➕ packages/vinext/src/server/app-page-response.ts (+232 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+624 -1362)
➕ tests/app-page-response.test.ts (+249 -0)
📝 tests/app-router.test.ts (+11 -6)

📄 Description

Summary

move App Router page response policy and final response construction into a typed server helper
keep the generated RSC entry focused on render orchestration while delegating RSC/HTML header policy, middleware merging, timing, and draft/font response finalization
add focused unit coverage for page response policy and response construction, plus generator assertion updates

Testing

vp check packages/vinext/src/server/app-page-response.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-response.test.ts tests/app-router.test.ts
vp test run tests/app-page-response.test.ts tests/app-router.test.ts -t "app page response helpers|generated code delegates|RSC stream tee"
vp test run tests/entry-templates.test.ts -u
vp test run tests/app-page-cache.test.ts tests/app-page-response.test.ts tests/nextjs-compat/app-routes.test.ts
vp run vinext#build

Stacked on #626.

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/627 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-render-policy-runtime` --- ### 📝 Commits (4) - [`749734a`](https://github.com/cloudflare/vinext/commit/749734a425c3056de7ebf65db9cb0bb8c4c7b7e4) refactor: extract app page response helpers - [`77852c5`](https://github.com/cloudflare/vinext/commit/77852c52437f8f3103093cc4b427e49916a6051f) test: refresh app page response snapshots - [`2d981f2`](https://github.com/cloudflare/vinext/commit/2d981f2823eccb04e11dbef7539223ceabb62168) docs: clarify app page response miss policy - [`f32a3bb`](https://github.com/cloudflare/vinext/commit/f32a3bb47254a80f3ea2ef562c7f8628a2b86514) test: document app page response policy edges ### 📊 Changes **5 files changed** (+1222 additions, -1594 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+106 -226) ➕ `packages/vinext/src/server/app-page-response.ts` (+232 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+624 -1362) ➕ `tests/app-page-response.test.ts` (+249 -0) 📝 `tests/app-router.test.ts` (+11 -6) </details> ### 📄 Description ## Summary - move App Router page response policy and final response construction into a typed server helper - keep the generated RSC entry focused on render orchestration while delegating RSC/HTML header policy, middleware merging, timing, and draft/font response finalization - add focused unit coverage for page response policy and response construction, plus generator assertion updates ## Testing - vp check packages/vinext/src/server/app-page-response.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-response.test.ts tests/app-router.test.ts - vp test run tests/app-page-response.test.ts tests/app-router.test.ts -t "app page response helpers|generated code delegates|RSC stream tee" - vp test run tests/entry-templates.test.ts -u - vp test run tests/app-page-cache.test.ts tests/app-page-response.test.ts tests/nextjs-compat/app-routes.test.ts - vp run vinext#build Stacked on #626. Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>