[PR #628] [MERGED] refactor: extract app page cache writes #726

New issue

Closed

opened 2026-05-06 13:09:49 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:49 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/628
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/21/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-cache-write-runtime

📝 Commits (1)

a670cc4 refactor: extract app page cache writes

📊 Changes

4 files changed (+302 additions, -385 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+21 -55)
📝 packages/vinext/src/server/app-page-cache.ts (+77 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+126 -330)
📝 tests/app-page-cache.test.ts (+78 -0)

📄 Description

Summary

move App Router APP_PAGE HTML cache tee/write orchestration into the typed page-cache helper
keep the generated entry focused on rendering and delegate the HTML/RSC cache population flow after a MISS
add focused unit coverage for the finalized HTML cache response path and update entry snapshots

Testing

vp check packages/vinext/src/server/app-page-cache.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-cache.test.ts tests/app-router.test.ts
vp test run tests/app-page-cache.test.ts tests/app-router.test.ts -t "app page cache helpers|generated code|RSC stream tee"
vp test run tests/entry-templates.test.ts -u
vp test run tests/app-page-cache.test.ts tests/app-page-response.test.ts tests/nextjs-compat/app-routes.test.ts
vp run vinext#build

Stacked on #627.

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/628 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-cache-write-runtime` --- ### 📝 Commits (1) - [`a670cc4`](https://github.com/cloudflare/vinext/commit/a670cc4fc7b65407f6b439a02e305f2967136496) refactor: extract app page cache writes ### 📊 Changes **4 files changed** (+302 additions, -385 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+21 -55) 📝 `packages/vinext/src/server/app-page-cache.ts` (+77 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+126 -330) 📝 `tests/app-page-cache.test.ts` (+78 -0) </details> ### 📄 Description ## Summary - move App Router APP_PAGE HTML cache tee/write orchestration into the typed page-cache helper - keep the generated entry focused on rendering and delegate the HTML/RSC cache population flow after a MISS - add focused unit coverage for the finalized HTML cache response path and update entry snapshots ## Testing - vp check packages/vinext/src/server/app-page-cache.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-cache.test.ts tests/app-router.test.ts - vp test run tests/app-page-cache.test.ts tests/app-router.test.ts -t "app page cache helpers|generated code|RSC stream tee" - vp test run tests/entry-templates.test.ts -u - vp test run tests/app-page-cache.test.ts tests/app-page-response.test.ts tests/nextjs-compat/app-routes.test.ts - vp run vinext#build Stacked on #627. Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

BreizhHardware

2026-05-06 13:09:49 +02:00

closed this issue
added the
pull-request
label

Rows
Columns