[PR #630] [MERGED] refactor: extract app page execution helpers #728

New issue

Closed

opened 2026-05-06 13:09:49 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:49 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/630
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/21/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-execution-runtime

📝 Commits (1)

02dea81 refactor: extract app page execution helpers

📊 Changes

5 files changed (+1248 additions, -1256 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+124 -178)
➕ packages/vinext/src/server/app-page-execution.ts (+213 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+726 -1068)
➕ tests/app-page-execution.test.ts (+167 -0)
📝 tests/app-router.test.ts (+18 -10)

📄 Description

Summary

continue hollowing out app-rsc-entry.ts by moving page probe, special-error, font-link, and RSC capture utilities into a real typed runtime module
wire the App Router RSC entry through app-page-execution.ts for build errors, layout/page probes, background regeneration capture, and shared font-link generation
add focused unit coverage for the new helper layer and update generated-entry assertions/snapshots

Testing

vp check packages/vinext/src/server/app-page-execution.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-execution.test.ts tests/app-router.test.ts
vp test run tests/app-page-execution.test.ts tests/app-router.test.ts -t "generated code|page ISR \+ searchParams|app page execution helpers"
vp test run tests/entry-templates.test.ts -u
vp test run tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts
vp run vinext#build

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/630 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-execution-runtime` --- ### 📝 Commits (1) - [`02dea81`](https://github.com/cloudflare/vinext/commit/02dea81687c609161a4c7e6bdf9125f9258111d0) refactor: extract app page execution helpers ### 📊 Changes **5 files changed** (+1248 additions, -1256 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+124 -178) ➕ `packages/vinext/src/server/app-page-execution.ts` (+213 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+726 -1068) ➕ `tests/app-page-execution.test.ts` (+167 -0) 📝 `tests/app-router.test.ts` (+18 -10) </details> ### 📄 Description ## Summary - continue hollowing out `app-rsc-entry.ts` by moving page probe, special-error, font-link, and RSC capture utilities into a real typed runtime module - wire the App Router RSC entry through `app-page-execution.ts` for build errors, layout/page probes, background regeneration capture, and shared font-link generation - add focused unit coverage for the new helper layer and update generated-entry assertions/snapshots ## Testing - `vp check packages/vinext/src/server/app-page-execution.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-execution.test.ts tests/app-router.test.ts` - `vp test run tests/app-page-execution.test.ts tests/app-router.test.ts -t "generated code|page ISR \+ searchParams|app page execution helpers"` - `vp test run tests/entry-templates.test.ts -u` - `vp test run tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts` - `vp run vinext#build` Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>