[PR #631] [MERGED] fix: HL flight hint regex not matching correct format #729

Closed
opened 2026-05-06 13:09:50 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/631
Author: @james-elicx
Created: 3/21/2026
Status: Merged
Merged: 3/21/2026
Merged by: @james-elicx

Base: mainHead: opencode/glowing-island


📝 Commits (3)

📊 Changes

5 files changed (+46 additions, -18 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+1 -1)
📝 packages/vinext/src/server/app-ssr-stream.ts (+1 -1)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+6 -6)
📝 tests/app-router.test.ts (+32 -8)
📝 tests/app-ssr-stream.test.ts (+6 -2)

📄 Description

Turns out the regex was slightly incorrect and not matching, therefore not applying the fixes it was supposed to and surfacing invalid as="stylesheet" values in the link tags.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/631 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `opencode/glowing-island` --- ### 📝 Commits (3) - [`ad05dd0`](https://github.com/cloudflare/vinext/commit/ad05dd002fb01b5106aed4a28e712dc0a9d24e18) fix: HL flight hint regex not matching correct format - [`cc2c645`](https://github.com/cloudflare/vinext/commit/cc2c64511e843a4952027bcc16514cbee902bc94) update test - [`8096754`](https://github.com/cloudflare/vinext/commit/809675434c066a8884890115d2bcbc74a7ed09a2) update tests ### 📊 Changes **5 files changed** (+46 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+1 -1) 📝 `packages/vinext/src/server/app-ssr-stream.ts` (+1 -1) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+6 -6) 📝 `tests/app-router.test.ts` (+32 -8) 📝 `tests/app-ssr-stream.test.ts` (+6 -2) </details> ### 📄 Description Turns out the regex was slightly incorrect and not matching, therefore not applying the fixes it was supposed to and surfacing invalid `as="stylesheet"` values in the `link` tags. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 13:09:50 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#729
No description provided.