[PR #632] [MERGED] refactor: extract app page stream helpers #730

New issue

Closed

opened 2026-05-06 13:09:50 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:50 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/632
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/21/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-stream-runtime

📝 Commits (1)

455d664 refactor: extract app page stream helpers

📊 Changes

5 files changed (+614 additions, -297 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+59 -46)
➕ packages/vinext/src/server/app-page-stream.ts (+107 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+306 -251)
➕ tests/app-page-stream.test.ts (+131 -0)
📝 tests/app-router.test.ts (+11 -0)

📄 Description

Summary

extract the remaining repeated App Router page stream/SSR handoff helpers from app-rsc-entry.ts into a typed runtime module
delegate fallback/error HTML responses, main-page SSR handoff, font data collection, and RSC error tracking through app-page-stream.ts
add focused unit coverage for the new helper and update generated-entry assertions/snapshots

Testing

vp check packages/vinext/src/server/app-page-stream.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-stream.test.ts tests/app-router.test.ts
vp test run tests/app-page-stream.test.ts tests/app-router.test.ts -t "app page stream helpers|generated code delegates page HTML stream plumbing|generated code delegates page probes|RSC stream tee for rscData capture happens before the RSC response is returned"
vp test run tests/app-page-stream.test.ts tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts
vp test run tests/entry-templates.test.ts -u
vp test run tests/app-router.test.ts -t "generated code|page ISR \+ searchParams"
vp run vinext#build

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/632 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-stream-runtime` --- ### 📝 Commits (1) - [`455d664`](https://github.com/cloudflare/vinext/commit/455d664f45e7480c564943370a94bcbf031326cb) refactor: extract app page stream helpers ### 📊 Changes **5 files changed** (+614 additions, -297 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+59 -46) ➕ `packages/vinext/src/server/app-page-stream.ts` (+107 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+306 -251) ➕ `tests/app-page-stream.test.ts` (+131 -0) 📝 `tests/app-router.test.ts` (+11 -0) </details> ### 📄 Description ## Summary - extract the remaining repeated App Router page stream/SSR handoff helpers from `app-rsc-entry.ts` into a typed runtime module - delegate fallback/error HTML responses, main-page SSR handoff, font data collection, and RSC error tracking through `app-page-stream.ts` - add focused unit coverage for the new helper and update generated-entry assertions/snapshots ## Testing - `vp check packages/vinext/src/server/app-page-stream.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-stream.test.ts tests/app-router.test.ts` - `vp test run tests/app-page-stream.test.ts tests/app-router.test.ts -t "app page stream helpers|generated code delegates page HTML stream plumbing|generated code delegates page probes|RSC stream tee for rscData capture happens before the RSC response is returned"` - `vp test run tests/app-page-stream.test.ts tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts` - `vp test run tests/entry-templates.test.ts -u` - `vp test run tests/app-router.test.ts -t "generated code|page ISR \+ searchParams"` - `vp run vinext#build` Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>