[PR #633] [MERGED] refactor: extract app page request helpers #732

New issue

Closed

opened 2026-05-06 13:09:51 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:51 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/633
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/21/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-request-runtime

📝 Commits (2)

fa84bba refactor: extract app page request helpers
869b671 test: fix app router integration assertions

📊 Changes

5 files changed (+945 additions, -519 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+77 -73)
➕ packages/vinext/src/server/app-page-request.ts (+189 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+444 -438)
➕ tests/app-page-request.test.ts (+211 -0)
📝 tests/app-router.test.ts (+24 -8)

📄 Description

Summary

extract App Router page request/intercept/build orchestration into app-page-request.ts
keep app-rsc-entry.ts focused on generated wiring by delegating dynamic params validation, intercept resolution, and special-error-aware page builds to typed helpers
add focused helper tests and refresh generated-entry assertions/snapshots

Testing

vp check packages/vinext/src/server/app-page-request.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-request.test.ts tests/app-router.test.ts
vp test run tests/app-page-request.test.ts tests/app-router.test.ts -t 'app page request helpers|generated code delegates page request orchestration'
vp test run tests/app-page-request.test.ts tests/app-page-stream.test.ts tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts
vp test run tests/entry-templates.test.ts -u
vp test run tests/app-router.test.ts -t 'generated code|dynamicParams|intercepted photo modal|page ISR \+ searchParams'
vp run vinext#build

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/633 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-request-runtime` --- ### 📝 Commits (2) - [`fa84bba`](https://github.com/cloudflare/vinext/commit/fa84bba2049b2be9212322c17d93a69c74554a82) refactor: extract app page request helpers - [`869b671`](https://github.com/cloudflare/vinext/commit/869b67106035dfee50a5e75a4ad9301f7c66dfb3) test: fix app router integration assertions ### 📊 Changes **5 files changed** (+945 additions, -519 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+77 -73) ➕ `packages/vinext/src/server/app-page-request.ts` (+189 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+444 -438) ➕ `tests/app-page-request.test.ts` (+211 -0) 📝 `tests/app-router.test.ts` (+24 -8) </details> ### 📄 Description ## Summary - extract App Router page request/intercept/build orchestration into `app-page-request.ts` - keep `app-rsc-entry.ts` focused on generated wiring by delegating dynamic params validation, intercept resolution, and special-error-aware page builds to typed helpers - add focused helper tests and refresh generated-entry assertions/snapshots ## Testing - `vp check packages/vinext/src/server/app-page-request.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-request.test.ts tests/app-router.test.ts` - `vp test run tests/app-page-request.test.ts tests/app-router.test.ts -t 'app page request helpers|generated code delegates page request orchestration'` - `vp test run tests/app-page-request.test.ts tests/app-page-stream.test.ts tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts` - `vp test run tests/entry-templates.test.ts -u` - `vp test run tests/app-router.test.ts -t 'generated code|dynamicParams|intercepted photo modal|page ISR \+ searchParams'` - `vp run vinext#build` Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>