[PR #635] [MERGED] refactor: extract app page probe runtime #733

New issue

Closed

opened 2026-05-06 13:09:51 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:51 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/635
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/21/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-probe-runtime

📝 Commits (2)

1d33813 refactor: extract app page probe runtime
faf248f fix: handle SSR special errors in app page render

📊 Changes

5 files changed (+722 additions, -738 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+72 -105)
➕ packages/vinext/src/server/app-page-probe.ts (+68 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+414 -630)
➕ tests/app-page-probe.test.ts (+158 -0)
📝 tests/app-router.test.ts (+10 -3)

📄 Description

Summary

extract the App Router pre-render probe orchestration into a typed app-page-probe helper
keep app-rsc-entry.ts focused on route-specific wiring while delegating layout/page probe handling to the helper
add focused helper coverage and update generated-entry assertions/snapshots for the new boundary

Testing

vp check packages/vinext/src/server/app-page-probe.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-probe.test.ts tests/app-router.test.ts
vp test run tests/app-page-probe.test.ts tests/app-page-boundary.test.ts tests/app-page-request.test.ts tests/app-page-stream.test.ts tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts tests/error-boundary.test.ts
vp test run tests/entry-templates.test.ts tests/app-router.test.ts -t "generated code|dynamicParams = false|page ISR + searchParams|notFound() inside Suspense boundary preserves digest for not-found UI|renders intercepted photo modal on RSC navigation from feed|renders custom not-found.tsx for unmatched routes|notFound() escalates to nearest ancestor not-found.tsx|forbidden() from Server Component returns 403 with forbidden.tsx|unauthorized() from Server Component returns 401 with unauthorized.tsx|renders error boundary wrapper for routes with error.tsx"
vp run vinext#build

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/635 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/21/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-probe-runtime` --- ### 📝 Commits (2) - [`1d33813`](https://github.com/cloudflare/vinext/commit/1d338138a8857c753aa2a3943f8186231e721899) refactor: extract app page probe runtime - [`faf248f`](https://github.com/cloudflare/vinext/commit/faf248f6c7eef26a3ba18963b9ccb04578266252) fix: handle SSR special errors in app page render ### 📊 Changes **5 files changed** (+722 additions, -738 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+72 -105) ➕ `packages/vinext/src/server/app-page-probe.ts` (+68 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+414 -630) ➕ `tests/app-page-probe.test.ts` (+158 -0) 📝 `tests/app-router.test.ts` (+10 -3) </details> ### 📄 Description ## Summary - extract the App Router pre-render probe orchestration into a typed `app-page-probe` helper - keep `app-rsc-entry.ts` focused on route-specific wiring while delegating layout/page probe handling to the helper - add focused helper coverage and update generated-entry assertions/snapshots for the new boundary ## Testing - vp check packages/vinext/src/server/app-page-probe.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-probe.test.ts tests/app-router.test.ts - vp test run tests/app-page-probe.test.ts tests/app-page-boundary.test.ts tests/app-page-request.test.ts tests/app-page-stream.test.ts tests/app-page-execution.test.ts tests/app-page-cache.test.ts tests/app-page-response.test.ts tests/error-boundary.test.ts - vp test run tests/entry-templates.test.ts tests/app-router.test.ts -t "generated code|dynamicParams = false|page ISR + searchParams|notFound\(\) inside Suspense boundary preserves digest for not-found UI|renders intercepted photo modal on RSC navigation from feed|renders custom not-found.tsx for unmatched routes|notFound\(\) escalates to nearest ancestor not-found.tsx|forbidden\(\) from Server Component returns 403 with forbidden.tsx|unauthorized\(\) from Server Component returns 401 with unauthorized.tsx|renders error boundary wrapper for routes with error.tsx" - vp run vinext#build Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>