[PR #636] [MERGED] refactor: extract app page html recovery runtime #734

New issue

Closed

opened 2026-05-06 13:09:51 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:51 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/636
Author: @southpolesteve
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/22/2026
Merged by: @southpolesteve

Base: main ← Head: codex/app-page-render-runtime

📝 Commits (1)

d1461d9 refactor: extract app page html recovery runtime

📊 Changes

5 files changed (+394 additions, -247 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+37 -35)
📝 packages/vinext/src/server/app-page-stream.ts (+44 -0)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+222 -210)
📝 tests/app-page-stream.test.ts (+83 -0)
📝 tests/app-router.test.ts (+8 -2)

📄 Description

Summary

extract the App Router HTML SSR recovery flow into the typed app-page-stream runtime helper
keep app-rsc-entry.ts focused on wiring while delegating HTML stream recovery, special-error handling, and boundary fallback selection to typed code
add focused runtime coverage and refresh generated-entry assertions/snapshots for the new helper boundary

Testing

vp check packages/vinext/src/server/app-page-stream.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-stream.test.ts tests/app-router.test.ts
vp test run tests/app-page-stream.test.ts tests/app-page-boundary.test.ts tests/app-page-cache.test.ts tests/app-page-execution.test.ts tests/app-page-probe.test.ts tests/app-page-request.test.ts tests/app-page-response.test.ts tests/error-boundary.test.ts
vp test run tests/app-page-stream.test.ts tests/nextjs-compat/global-error.test.ts
vp test run tests/entry-templates.test.ts -u
vp test run tests/app-router.test.ts -t "generated code handles SSR special errors without a legacy handleRenderError helper|generated code delegates page HTML stream plumbing to typed helpers|redirect\(\) inside Suspense boundary preserves digest in RSC payload|notFound\(\) inside Suspense boundary preserves digest for not-found UI|renders error boundary wrapper for routes with error.tsx"
vp run vinext#build

Written by Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/636 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/22/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `codex/app-page-render-runtime` --- ### 📝 Commits (1) - [`d1461d9`](https://github.com/cloudflare/vinext/commit/d1461d98b2128f3528fa91e15bc3bc6e3d3f978d) refactor: extract app page html recovery runtime ### 📊 Changes **5 files changed** (+394 additions, -247 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+37 -35) 📝 `packages/vinext/src/server/app-page-stream.ts` (+44 -0) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+222 -210) 📝 `tests/app-page-stream.test.ts` (+83 -0) 📝 `tests/app-router.test.ts` (+8 -2) </details> ### 📄 Description ## Summary - extract the App Router HTML SSR recovery flow into the typed `app-page-stream` runtime helper - keep `app-rsc-entry.ts` focused on wiring while delegating HTML stream recovery, special-error handling, and boundary fallback selection to typed code - add focused runtime coverage and refresh generated-entry assertions/snapshots for the new helper boundary ## Testing - `vp check packages/vinext/src/server/app-page-stream.ts packages/vinext/src/entries/app-rsc-entry.ts tests/app-page-stream.test.ts tests/app-router.test.ts` - `vp test run tests/app-page-stream.test.ts tests/app-page-boundary.test.ts tests/app-page-cache.test.ts tests/app-page-execution.test.ts tests/app-page-probe.test.ts tests/app-page-request.test.ts tests/app-page-response.test.ts tests/error-boundary.test.ts` - `vp test run tests/app-page-stream.test.ts tests/nextjs-compat/global-error.test.ts` - `vp test run tests/entry-templates.test.ts -u` - `vp test run tests/app-router.test.ts -t "generated code handles SSR special errors without a legacy handleRenderError helper|generated code delegates page HTML stream plumbing to typed helpers|redirect\(\) inside Suspense boundary preserves digest in RSC payload|notFound\(\) inside Suspense boundary preserves digest for not-found UI|renders error boundary wrapper for routes with error.tsx"` - `vp run vinext#build` Written by Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>