[PR #678] [CLOSED] fix: encode non-ASCII route params in X-Vinext-Params header #763

New issue

Closed

opened 2026-05-06 13:09:59 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:09:59 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/678
Author: @seoJing
Created: 3/24/2026
Status: ❌ Closed

Base: main ← Head: fix/non-ascii-rsc-params

📝 Commits (1)

31cea27 fix: percent-encode non-ASCII params in RSC header

📊 Changes

3 files changed (+476 additions, -429 deletions)

View changed files

📝 packages/vinext/src/server/app-browser-entry.ts (+2 -2)
📝 packages/vinext/src/server/app-page-response.ts (+201 -188)
📝 tests/app-page-response.test.ts (+273 -239)

📄 Description

Non-ASCII characters in dynamic route parameters (e.g., Korean slugs) cause a ByteString TypeError when set as HTTP header values during RSC streaming. Percent-encode the JSON before setting the header.

Fixes #676

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/678 **Author:** [@seoJing](https://github.com/seoJing) **Created:** 3/24/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/non-ascii-rsc-params` --- ### 📝 Commits (1) - [`31cea27`](https://github.com/cloudflare/vinext/commit/31cea277f239153930277faca727482822609b8f) fix: percent-encode non-ASCII params in RSC header ### 📊 Changes **3 files changed** (+476 additions, -429 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-browser-entry.ts` (+2 -2) 📝 `packages/vinext/src/server/app-page-response.ts` (+201 -188) 📝 `tests/app-page-response.test.ts` (+273 -239) </details> ### 📄 Description Non-ASCII characters in dynamic route parameters (e.g., Korean slugs) cause a ByteString TypeError when set as HTTP header values during RSC streaming. Percent-encode the JSON before setting the header. Fixes #676 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>