[PR #694] [MERGED] fix(app-router-playground): clean warnings and stabilize checks #777

New issue

Closed

opened 2026-05-06 13:10:03 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/694
Author: @haddoumounir
Created: 3/26/2026
Status: ✅ Merged
Merged: 3/28/2026
Merged by: @james-elicx

Base: main ← Head: fix/app-router-playground-react-doctor-build-warnings

📝 Commits (1)

ef77913 fix(app-router-playground): resolve React Doctor findings and build warnings

📊 Changes

16 files changed (+118 additions, -57 deletions)

View changed files

📝 examples/app-router-playground/app/_patterns/breadcrumbs/@breadcrumbs/[...all]/page.tsx (+5 -7)
📝 examples/app-router-playground/app/api/og/route.tsx (+9 -7)
📝 examples/app-router-playground/app/context/context-click-counter.tsx (+1 -1)
📝 examples/app-router-playground/app/loading/[section]/[category]/page.tsx (+7 -6)
📝 examples/app-router-playground/app/loading/[section]/page.tsx (+7 -6)
📝 examples/app-router-playground/app/private-cache/_components/product-list.tsx (+2 -3)
📝 examples/app-router-playground/app/private-cache/_components/recommendations.tsx (+2 -2)
📝 examples/app-router-playground/app/private-cache/product/[id]/loading.tsx (+2 -2)
📝 examples/app-router-playground/app/private-cache/product/[id]/with-private/page.tsx (+2 -2)
📝 examples/app-router-playground/app/private-cache/product/[id]/without-private/page.tsx (+2 -2)
📝 examples/app-router-playground/app/use-link-status/[section]/[category]/page.tsx (+7 -6)
📝 examples/app-router-playground/ui/click-counter.tsx (+1 -1)
📝 examples/app-router-playground/ui/codehike.tsx (+35 -8)
📝 examples/app-router-playground/ui/skeleton.tsx (+9 -4)
📝 examples/app-router-playground/vite.config.ts (+23 -0)
📝 examples/app-router-playground/worker/index.ts (+4 -0)

📄 Description

Summary

fix async loading pages to run independent awaits in parallel
replace unstable list keys and stale setState updates in playground components
fix SVG JSX property casing for OG route output
reduce LightSvg component size by extracting static markup constant
remove rolldown client build warnings by stripping unsupported rollup keys in playground Vite config
fix additional playground lint/type issues found during validation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/694 **Author:** [@haddoumounir](https://github.com/haddoumounir) **Created:** 3/26/2026 **Status:** ✅ Merged **Merged:** 3/28/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/app-router-playground-react-doctor-build-warnings` --- ### 📝 Commits (1) - [`ef77913`](https://github.com/cloudflare/vinext/commit/ef77913eaad2fe479230a9beea1584537581d843) fix(app-router-playground): resolve React Doctor findings and build warnings ### 📊 Changes **16 files changed** (+118 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `examples/app-router-playground/app/_patterns/breadcrumbs/@breadcrumbs/[...all]/page.tsx` (+5 -7) 📝 `examples/app-router-playground/app/api/og/route.tsx` (+9 -7) 📝 `examples/app-router-playground/app/context/context-click-counter.tsx` (+1 -1) 📝 `examples/app-router-playground/app/loading/[section]/[category]/page.tsx` (+7 -6) 📝 `examples/app-router-playground/app/loading/[section]/page.tsx` (+7 -6) 📝 `examples/app-router-playground/app/private-cache/_components/product-list.tsx` (+2 -3) 📝 `examples/app-router-playground/app/private-cache/_components/recommendations.tsx` (+2 -2) 📝 `examples/app-router-playground/app/private-cache/product/[id]/loading.tsx` (+2 -2) 📝 `examples/app-router-playground/app/private-cache/product/[id]/with-private/page.tsx` (+2 -2) 📝 `examples/app-router-playground/app/private-cache/product/[id]/without-private/page.tsx` (+2 -2) 📝 `examples/app-router-playground/app/use-link-status/[section]/[category]/page.tsx` (+7 -6) 📝 `examples/app-router-playground/ui/click-counter.tsx` (+1 -1) 📝 `examples/app-router-playground/ui/codehike.tsx` (+35 -8) 📝 `examples/app-router-playground/ui/skeleton.tsx` (+9 -4) 📝 `examples/app-router-playground/vite.config.ts` (+23 -0) 📝 `examples/app-router-playground/worker/index.ts` (+4 -0) </details> ### 📄 Description ## Summary - fix async loading pages to run independent awaits in parallel - replace unstable list keys and stale setState updates in playground components - fix SVG JSX property casing for OG route output - reduce LightSvg component size by extracting static markup constant - remove rolldown client build warnings by stripping unsupported rollup keys in playground Vite config - fix additional playground lint/type issues found during validation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>