[PR #770] [MERGED] fix: restore baseUrl in hackernews tsconfig to fix build #831

New issue

Closed

opened 2026-05-06 13:10:22 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:22 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/770
Author: @james-elicx
Created: 4/3/2026
Status: ✅ Merged
Merged: 4/3/2026
Merged by: @james-elicx

Base: main ← Head: fix/hackernews-baseurl-resolution

📝 Commits (1)

56dd4ac fix: restore baseUrl in hackernews tsconfig to fix bare-specifier resolution

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 examples/hackernews/tsconfig.json (+1 -0)

📄 Description

Problem

The hackernews example build was broken by the security audit PR (#769), which removed "baseUrl": "." from examples/hackernews/tsconfig.json as a TypeScript 6 deprecation cleanup.

That option is load-bearing: the entire app/ and components/ tree uses bare specifiers ('components/skeletons', 'lib/get-comments', 'components/comment', etc.) that Vite resolves by reading baseUrl from the tsconfig. Without it, Rolldown cannot find those modules and the RSC build fails:

Error: [vite+]: Rolldown failed to resolve import "components/skeletons"
from ".../examples/hackernews/app/item/[id]/(comments)/loading.tsx".

Fix

Restore "baseUrl": ".". The noEmit: true addition from #769 is kept — only the baseUrl removal is reverted.

Other examples (app-router-playground, fumadocs-docs-template) already keep baseUrl for the same reason. When TypeScript 7 actually removes support, the right fix will be to switch to explicit paths aliases or add vite-tsconfig-paths — not to silently break the app.

Fixes the deploy regression introduced by #769.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/770 **Author:** [@james-elicx](https://github.com/james-elicx) **Created:** 4/3/2026 **Status:** ✅ Merged **Merged:** 4/3/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/hackernews-baseurl-resolution` --- ### 📝 Commits (1) - [`56dd4ac`](https://github.com/cloudflare/vinext/commit/56dd4acb078f2c7073fbb72bdb6fb59279b71c81) fix: restore baseUrl in hackernews tsconfig to fix bare-specifier resolution ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `examples/hackernews/tsconfig.json` (+1 -0) </details> ### 📄 Description ## Problem The hackernews example build was broken by the security audit PR (#769), which removed `"baseUrl": "."` from `examples/hackernews/tsconfig.json` as a TypeScript 6 deprecation cleanup. That option is load-bearing: the entire `app/` and `components/` tree uses bare specifiers (`'components/skeletons'`, `'lib/get-comments'`, `'components/comment'`, etc.) that Vite resolves by reading `baseUrl` from the tsconfig. Without it, Rolldown cannot find those modules and the RSC build fails: ``` Error: [vite+]: Rolldown failed to resolve import "components/skeletons" from ".../examples/hackernews/app/item/[id]/(comments)/loading.tsx". ``` ## Fix Restore `"baseUrl": "."`. The `noEmit: true` addition from #769 is kept — only the `baseUrl` removal is reverted. Other examples (`app-router-playground`, `fumadocs-docs-template`) already keep `baseUrl` for the same reason. When TypeScript 7 actually removes support, the right fix will be to switch to explicit `paths` aliases or add `vite-tsconfig-paths` — not to silently break the app. Fixes the deploy regression introduced by #769. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>