[PR #789] [MERGED] fix(app-route): merge middleware headers with override semantics #846

New issue

Closed

opened 2026-05-06 13:10:26 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:26 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/789
Author: @NathanDrake2406
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @james-elicx

Base: main ← Head: fix/bug4-route-handler-merge

📝 Commits (3)

9321f46 fix(app-route): merge middleware headers with override semantics
92bd009 refactor(app-route): share middleware header merge helper
ae02936 fix(app-page): apply shared middleware header merge to HTML

📊 Changes

5 files changed (+67 additions, -40 deletions)

View changed files

📝 packages/vinext/src/server/app-page-response.ts (+4 -32)
📝 packages/vinext/src/server/app-route-handler-response.ts (+2 -5)
➕ packages/vinext/src/server/middleware-response-headers.ts (+26 -0)
📝 tests/app-page-response.test.ts (+2 -1)
📝 tests/app-route-handler-response.test.ts (+33 -2)

📄 Description

Summary

update applyRouteHandlerMiddlewareContext to merge middleware response headers with Next-like semantics
treat set-cookie and vary as additive headers (append)
treat all other headers as singular override headers (set), so middleware can override route handler values like cache-control
add regression coverage for singular override and additive merge behavior

Verification

vp test run tests/app-route-handler-response.test.ts tests/app-route-handler-cache.test.ts tests/app-route-handler-execution.test.ts tests/app-route-handler-policy.test.ts tests/app-route-handler-runtime.test.ts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/789 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/bug4-route-handler-merge` --- ### 📝 Commits (3) - [`9321f46`](https://github.com/cloudflare/vinext/commit/9321f4618ed2c2bf65ce07eb9d6e6ece8732f73e) fix(app-route): merge middleware headers with override semantics - [`92bd009`](https://github.com/cloudflare/vinext/commit/92bd0091416cf6b204b2f65ee4dcd62780efb1bc) refactor(app-route): share middleware header merge helper - [`ae02936`](https://github.com/cloudflare/vinext/commit/ae0293625edc774136bd7995f2702da583d7ae33) fix(app-page): apply shared middleware header merge to HTML ### 📊 Changes **5 files changed** (+67 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-page-response.ts` (+4 -32) 📝 `packages/vinext/src/server/app-route-handler-response.ts` (+2 -5) ➕ `packages/vinext/src/server/middleware-response-headers.ts` (+26 -0) 📝 `tests/app-page-response.test.ts` (+2 -1) 📝 `tests/app-route-handler-response.test.ts` (+33 -2) </details> ### 📄 Description ## Summary - update `applyRouteHandlerMiddlewareContext` to merge middleware response headers with Next-like semantics - treat `set-cookie` and `vary` as additive headers (append) - treat all other headers as singular override headers (`set`), so middleware can override route handler values like `cache-control` - add regression coverage for singular override and additive merge behavior ## Verification - `vp test run tests/app-route-handler-response.test.ts tests/app-route-handler-cache.test.ts tests/app-route-handler-execution.test.ts tests/app-route-handler-policy.test.ts tests/app-route-handler-runtime.test.ts` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>