[PR #790] [MERGED] fix(app-router): apply slot override params to parallel slot segment map #849

New issue

Closed

opened 2026-05-06 13:10:27 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:27 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/790
Author: @NathanDrake2406
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @james-elicx

Base: main ← Head: fix/bug2-slot-override-segments

📝 Commits (2)

2b1daf0 fix(app-router): apply slot override params to slot segment map
14dc4b5 refactor(app-router): dedupe effective slot params lookup

📊 Changes

2 files changed (+91 additions, -2 deletions)

View changed files

📝 packages/vinext/src/server/app-page-route-wiring.tsx (+5 -2)
📝 tests/app-page-route-wiring.test.ts (+86 -0)

📄 Description

Summary

make slot segment-map resolution use the same effective params as slot rendering (slotOverride.params when present, otherwise matched route params)
keep behavior unchanged when no override exists
add regression coverage in app-page-route-wiring for both override and non-override paths

Testing

vp check tests/app-page-route-wiring.test.ts packages/vinext/src/server/app-page-route-wiring.tsx
vp test run tests/app-page-route-wiring.test.ts

Notes

vp test run tests/app-router.test.ts -t "useSelectedLayoutSegments" is currently blocked in this worktree by an existing environment dependency error: Cannot find package 'magic-string' from packages/vinext/src/plugins/instrumentation-client.ts.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/790 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/bug2-slot-override-segments` --- ### 📝 Commits (2) - [`2b1daf0`](https://github.com/cloudflare/vinext/commit/2b1daf09227b8def77e45095ed4478a34d5b8004) fix(app-router): apply slot override params to slot segment map - [`14dc4b5`](https://github.com/cloudflare/vinext/commit/14dc4b5cc86be11c1fc6930defa9f6fd75eb0c6e) refactor(app-router): dedupe effective slot params lookup ### 📊 Changes **2 files changed** (+91 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-page-route-wiring.tsx` (+5 -2) 📝 `tests/app-page-route-wiring.test.ts` (+86 -0) </details> ### 📄 Description ## Summary - make slot segment-map resolution use the same effective params as slot rendering (`slotOverride.params` when present, otherwise matched route params) - keep behavior unchanged when no override exists - add regression coverage in `app-page-route-wiring` for both override and non-override paths ## Testing - `vp check tests/app-page-route-wiring.test.ts packages/vinext/src/server/app-page-route-wiring.tsx` - `vp test run tests/app-page-route-wiring.test.ts` ## Notes - `vp test run tests/app-router.test.ts -t "useSelectedLayoutSegments"` is currently blocked in this worktree by an existing environment dependency error: `Cannot find package 'magic-string'` from `packages/vinext/src/plugins/instrumentation-client.ts`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>