[PR #837] [MERGED] fix(shims): import local navigation module in error boundary #888

New issue

Closed

opened 2026-05-06 13:10:40 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:40 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/837
Author: @NathanDrake2406
Created: 4/14/2026
Status: ✅ Merged
Merged: 4/14/2026
Merged by: @james-elicx

Base: main ← Head: chore/shim-error-boundary

📝 Commits (1)

21894a0 fix(shims): import local navigation module in error boundary

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 packages/vinext/src/shims/error-boundary.tsx (+3 -2)

📄 Description

Summary

The built package can execute shims/error-boundary.tsx before the plugin's resolveId hook is active, so the public next/navigation alias is not yet registered. Import the local ./navigation.js module directly instead.

Three-line change extracted from the PR #768 restack; landing independently because it's orthogonal to the layout-persistence feature work.

Stack context

This is the sibling of the PR #768 restack. Not part of the 6-PR stack; open on its own.

Test plan

vp check on the shim file
Manual verification in examples/ that the error boundary still renders when thrown

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/837 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 4/14/2026 **Status:** ✅ Merged **Merged:** 4/14/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `chore/shim-error-boundary` --- ### 📝 Commits (1) - [`21894a0`](https://github.com/cloudflare/vinext/commit/21894a02f0971a2e8f8c27064bcbda8f03770f84) fix(shims): import local navigation module in error boundary ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/shims/error-boundary.tsx` (+3 -2) </details> ### 📄 Description ## Summary The built package can execute `shims/error-boundary.tsx` before the plugin's `resolveId` hook is active, so the public `next/navigation` alias is not yet registered. Import the local `./navigation.js` module directly instead. Three-line change extracted from the PR #768 restack; landing independently because it's orthogonal to the layout-persistence feature work. ## Stack context This is the sibling of the PR #768 restack. Not part of the 6-PR stack; open on its own. ## Test plan - [x] `vp check` on the shim file - [ ] Manual verification in `examples/` that the error boundary still renders when thrown --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>