[PR #851] [CLOSED] test(app-router): restore rapid-navigation no-reload assertions #897

New issue

Closed

opened 2026-05-06 13:10:43 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:43 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/851
Author: @Divkix
Created: 4/16/2026
Status: ❌ Closed

Base: main ← Head: fix/issue-796-rapid-nav-hard-reload

📝 Commits (2)

8b21afc test(app-router): restore rapid navigation reload assertions
f406949 test(e2e): stabilize rapid-navigation click dispatch

📊 Changes

1 file changed (+29 additions, -26 deletions)

View changed files

📝 tests/e2e/app-router/rapid-navigation.spec.ts (+29 -26)

📄 Description

Summary:
Re-enable NAV_MARKER assertions in tests/e2e/app-router/rapid-navigation.spec.ts

Cover both rapid cross-route A→B→C and same-route query-change cases
Keep existing console-error assertions

Why:
Issue #796 reported full-page reloads during rapid navigation, but current main no longer reproduces this when using the suite hydration gate (waitForAppRouterHydration).

This PR restores the regression assertions that were previously removed as a workaround, so this behavior stays locked in.

Validation:

pnpm exec playwright test --project app-router -- tests/e2e/app-router/rapid-navigation.spec.ts

Refs #796

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/851 **Author:** [@Divkix](https://github.com/Divkix) **Created:** 4/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/issue-796-rapid-nav-hard-reload` --- ### 📝 Commits (2) - [`8b21afc`](https://github.com/cloudflare/vinext/commit/8b21afcdce96cf34b103f68e50e784af466f8462) test(app-router): restore rapid navigation reload assertions - [`f406949`](https://github.com/cloudflare/vinext/commit/f406949a8f486d4088c2d53dd1b92bae77766e40) test(e2e): stabilize rapid-navigation click dispatch ### 📊 Changes **1 file changed** (+29 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `tests/e2e/app-router/rapid-navigation.spec.ts` (+29 -26) </details> ### 📄 Description Summary: Re-enable NAV_MARKER assertions in tests/e2e/app-router/rapid-navigation.spec.ts - Cover both rapid cross-route A→B→C and same-route query-change cases - Keep existing console-error assertions Why: Issue #796 reported full-page reloads during rapid navigation, but current main no longer reproduces this when using the suite hydration gate (waitForAppRouterHydration). This PR restores the regression assertions that were previously removed as a workaround, so this behavior stays locked in. Validation: - pnpm exec playwright test --project app-router -- tests/e2e/app-router/rapid-navigation.spec.ts Refs #796 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>