[PR #862] [MERGED] fix: preserve console output for caught app errors in dev #903

New issue

Closed

opened 2026-05-06 13:10:45 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:10:45 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/862
Author: @lyzno1
Created: 4/19/2026
Status: ✅ Merged
Merged: 4/20/2026
Merged by: @james-elicx

Base: main ← Head: fix/oncaughterror-preserve-console

📝 Commits (2)

d58039a fix: preserve console output for caught app errors in dev
260904e address bonk review comments on PR 862

📊 Changes

5 files changed (+94 additions, -4 deletions)

View changed files

📝 packages/vinext/src/check.ts (+5 -1)
📝 packages/vinext/src/server/app-browser-entry.ts (+2 -1)
➕ packages/vinext/src/server/app-browser-error.ts (+15 -0)
📝 tests/app-browser-entry.test.ts (+68 -1)
📝 tests/check.test.ts (+4 -1)

📄 Description

Summary

preserve console.error output for App Router client errors caught during hydration in dev
keep Vite's overlay suppression by avoiding redispatch through the window error path
mark reactStrictMode as partial until the hydrated root is actually wrapped in React.StrictMode

Testing

vp test run tests/app-browser-entry.test.ts tests/check.test.ts
vp test run tests/app-router.test.ts tests/nextjs-compat/global-error.test.ts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/862 **Author:** [@lyzno1](https://github.com/lyzno1) **Created:** 4/19/2026 **Status:** ✅ Merged **Merged:** 4/20/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/oncaughterror-preserve-console` --- ### 📝 Commits (2) - [`d58039a`](https://github.com/cloudflare/vinext/commit/d58039a245a8c3829c82b9874569c836b3cb8b3b) fix: preserve console output for caught app errors in dev - [`260904e`](https://github.com/cloudflare/vinext/commit/260904e2f6c05ed556585b37d104541c65ef830f) address bonk review comments on PR 862 ### 📊 Changes **5 files changed** (+94 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/check.ts` (+5 -1) 📝 `packages/vinext/src/server/app-browser-entry.ts` (+2 -1) ➕ `packages/vinext/src/server/app-browser-error.ts` (+15 -0) 📝 `tests/app-browser-entry.test.ts` (+68 -1) 📝 `tests/check.test.ts` (+4 -1) </details> ### 📄 Description ## Summary - preserve `console.error` output for App Router client errors caught during hydration in dev - keep Vite's overlay suppression by avoiding redispatch through the window error path - mark `reactStrictMode` as partial until the hydrated root is actually wrapped in `React.StrictMode` ## Testing - vp test run tests/app-browser-entry.test.ts tests/check.test.ts - vp test run tests/app-router.test.ts tests/nextjs-compat/global-error.test.ts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>