[PR #857] [CLOSED] chore: set oxfmt printWidth to 90 #904

Closed
opened 2026-05-06 13:10:45 +02:00 by BreizhHardware · 0 comments

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/857
Author: @NathanDrake2406
Created: 4/17/2026
Status: Closed

Base: mainHead: chore/print-width-85


📝 Commits (2)

  • 6e294e3 chore: set oxfmt printWidth to 90
  • f6bf581 chore: reformat codebase at printWidth 90

📊 Changes

328 files changed (+8436 additions, -2859 deletions)

View changed files

📝 .github/scripts/send-email.mjs (+9 -6)
📝 benchmarks/run.mjs (+39 -10)
📝 packages/vinext/src/build/client-build-config.ts (+3 -1)
📝 packages/vinext/src/build/precompress.ts (+2 -1)
📝 packages/vinext/src/build/prerender.ts (+75 -28)
📝 packages/vinext/src/build/report.ts (+15 -4)
📝 packages/vinext/src/build/run-prerender.ts (+10 -4)
📝 packages/vinext/src/build/ssr-manifest.ts (+4 -1)
📝 packages/vinext/src/build/standalone.ts (+13 -5)
📝 packages/vinext/src/build/static-export.ts (+3 -1)
📝 packages/vinext/src/check.ts (+82 -25)
📝 packages/vinext/src/cli.ts (+30 -9)
📝 packages/vinext/src/client/instrumentation-client.ts (+7 -2)
📝 packages/vinext/src/cloudflare/kv-cache-handler.ts (+42 -11)
📝 packages/vinext/src/cloudflare/tpr.ts (+36 -13)
📝 packages/vinext/src/config/config-matchers.ts (+30 -8)
📝 packages/vinext/src/config/dotenv.ts (+6 -1)
📝 packages/vinext/src/config/next-config.ts (+32 -10)
📝 packages/vinext/src/deploy.ts (+38 -11)
📝 packages/vinext/src/entries/app-rsc-entry.ts (+47 -13)

...and 80 more files

📄 Description

Summary

  • Lowers fmt.printWidth in vite.config.ts from 100 to 90 (closes #855).
  • Runs vp fmt across the repo so the tree matches the new width. The reformat lives in its own commit so it can be added to .git-blame-ignore-revs if desired.
  • Converts two // oxlint-disable-next-line … suppressions to paired /* oxlint-disable … */ / /* oxlint-enable … */ blocks in plugins/strip-server-exports.ts and server/middleware.ts. The single-line variants previously covered expressions that fit on one line at width 100; after wrapping to 90, only the top of the wrap remained suppressed. Block pairs are stable across any formatter width and do not introduce new suppressions.

No behavioral changes. This is a formatting-and-config PR.

Refs #855

Test plan

  • vp check (fmt + lint + type) passes on CI
  • vp test passes on CI
  • Playwright E2E passes on CI

Running the full suite locally isn't useful here (nothing runtime-facing changed), so CI is the source of truth.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/857 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 4/17/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chore/print-width-85` --- ### 📝 Commits (2) - [`6e294e3`](https://github.com/cloudflare/vinext/commit/6e294e359a66eb1463b116db07188bcab07ea00a) chore: set oxfmt printWidth to 90 - [`f6bf581`](https://github.com/cloudflare/vinext/commit/f6bf5818a42f8f3844fcee92f531d9ecb91f850d) chore: reformat codebase at printWidth 90 ### 📊 Changes **328 files changed** (+8436 additions, -2859 deletions) <details> <summary>View changed files</summary> 📝 `.github/scripts/send-email.mjs` (+9 -6) 📝 `benchmarks/run.mjs` (+39 -10) 📝 `packages/vinext/src/build/client-build-config.ts` (+3 -1) 📝 `packages/vinext/src/build/precompress.ts` (+2 -1) 📝 `packages/vinext/src/build/prerender.ts` (+75 -28) 📝 `packages/vinext/src/build/report.ts` (+15 -4) 📝 `packages/vinext/src/build/run-prerender.ts` (+10 -4) 📝 `packages/vinext/src/build/ssr-manifest.ts` (+4 -1) 📝 `packages/vinext/src/build/standalone.ts` (+13 -5) 📝 `packages/vinext/src/build/static-export.ts` (+3 -1) 📝 `packages/vinext/src/check.ts` (+82 -25) 📝 `packages/vinext/src/cli.ts` (+30 -9) 📝 `packages/vinext/src/client/instrumentation-client.ts` (+7 -2) 📝 `packages/vinext/src/cloudflare/kv-cache-handler.ts` (+42 -11) 📝 `packages/vinext/src/cloudflare/tpr.ts` (+36 -13) 📝 `packages/vinext/src/config/config-matchers.ts` (+30 -8) 📝 `packages/vinext/src/config/dotenv.ts` (+6 -1) 📝 `packages/vinext/src/config/next-config.ts` (+32 -10) 📝 `packages/vinext/src/deploy.ts` (+38 -11) 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+47 -13) _...and 80 more files_ </details> ### 📄 Description ## Summary - Lowers `fmt.printWidth` in `vite.config.ts` from `100` to `90` (closes #855). - Runs `vp fmt` across the repo so the tree matches the new width. The reformat lives in its own commit so it can be added to `.git-blame-ignore-revs` if desired. - Converts two `// oxlint-disable-next-line …` suppressions to paired `/* oxlint-disable … */` / `/* oxlint-enable … */` blocks in `plugins/strip-server-exports.ts` and `server/middleware.ts`. The single-line variants previously covered expressions that fit on one line at width 100; after wrapping to 90, only the top of the wrap remained suppressed. Block pairs are stable across any formatter width and do not introduce new suppressions. No behavioral changes. This is a formatting-and-config PR. Refs #855 ## Test plan - [ ] `vp check` (fmt + lint + type) passes on CI - [ ] `vp test` passes on CI - [ ] Playwright E2E passes on CI Running the full suite locally isn't useful here (nothing runtime-facing changed), so CI is the source of truth. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 13:10:45 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vinext#904
No description provided.