[PR #941] [MERGED] Shim next/root-params #968

New issue

Closed

opened 2026-05-06 13:11:18 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:11:18 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/941
Author: @Divkix
Created: 4/28/2026
Status: ✅ Merged
Merged: 4/28/2026
Merged by: @james-elicx

Base: main ← Head: fix/806-shim-next-root-params

📝 Commits (4)

3718738 fix(app-router): shim next root params
68a8755 fix: address review feedback
98e2280 address review feedback
b48bb10 test: update snapshots for root params cleanup change

📊 Changes

9 files changed (+470 additions, -353 deletions)

View changed files

📝 packages/vinext/src/entries/app-rsc-entry.ts (+37 -52)
📝 packages/vinext/src/index.ts (+36 -0)
📝 packages/vinext/src/routing/app-router.ts (+26 -0)
📝 packages/vinext/src/shims/request-state-types.ts (+1 -0)
➕ packages/vinext/src/shims/root-params.ts (+40 -0)
📝 packages/vinext/src/shims/unified-request-context.ts (+4 -1)
📝 tests/__snapshots__/entry-templates.test.ts.snap (+228 -300)
📝 tests/app-router.test.ts (+48 -0)
📝 tests/routing.test.ts (+50 -0)

📄 Description

Summary

Add generated next/root-params runtime exports based on App Router root layout params.
Track root layout params in the RSC request context separately from leaf route params.
Add scanner, runtime, and generated-entry regression coverage.

Fixes #806

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/941 **Author:** [@Divkix](https://github.com/Divkix) **Created:** 4/28/2026 **Status:** ✅ Merged **Merged:** 4/28/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/806-shim-next-root-params` --- ### 📝 Commits (4) - [`3718738`](https://github.com/cloudflare/vinext/commit/371873838895ca805dd9f28504aed27d4a77c5e8) fix(app-router): shim next root params - [`68a8755`](https://github.com/cloudflare/vinext/commit/68a87550167607cffa7a83c406e2e171c6f0765e) fix: address review feedback - [`98e2280`](https://github.com/cloudflare/vinext/commit/98e2280adec93e12394408a68e45284b481c5a6a) address review feedback - [`b48bb10`](https://github.com/cloudflare/vinext/commit/b48bb1010a1ee6316a557035a7303ba259fdd3f0) test: update snapshots for root params cleanup change ### 📊 Changes **9 files changed** (+470 additions, -353 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/entries/app-rsc-entry.ts` (+37 -52) 📝 `packages/vinext/src/index.ts` (+36 -0) 📝 `packages/vinext/src/routing/app-router.ts` (+26 -0) 📝 `packages/vinext/src/shims/request-state-types.ts` (+1 -0) ➕ `packages/vinext/src/shims/root-params.ts` (+40 -0) 📝 `packages/vinext/src/shims/unified-request-context.ts` (+4 -1) 📝 `tests/__snapshots__/entry-templates.test.ts.snap` (+228 -300) 📝 `tests/app-router.test.ts` (+48 -0) 📝 `tests/routing.test.ts` (+50 -0) </details> ### 📄 Description ## Summary - Add generated `next/root-params` runtime exports based on App Router root layout params. - Track root layout params in the RSC request context separately from leaf route params. - Add scanner, runtime, and generated-entry regression coverage. Fixes #806 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>