[PR #954] [MERGED] test(app-router): harden RSC route matching delegation assertion #981

New issue

Closed

opened 2026-05-06 13:11:22 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:11:22 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/954
Author: @NathanDrake2406
Created: 4/29/2026
Status: ✅ Merged
Merged: 4/29/2026
Merged by: @james-elicx

Base: main ← Head: nathan/rsc-route-matching-helper

📝 Commits (1)

c9c39cd test(app-router): update route matching delegation assertion

📊 Changes

1 file changed (+11 additions, -8 deletions)

View changed files

📝 tests/shims.test.ts (+11 -8)

📄 Description

What this changes

This updates the RSC route matching regression test now that the route/intercept matching runtime lives in createAppRscRouteMatcher.

Approach

Keep the generated-entry assertion focused on delegation to createAppRscRouteMatcher.
Check the extracted route-matching helper source for accidental decodeURIComponent(...) calls so the no-double-decode invariant follows the new ownership boundary.

Validation

vp check tests/shims.test.ts
vp test run tests/shims.test.ts -t "RSC route matching does not double-decode pathnames"
vp test run tests/shims.test.ts tests/app-rsc-route-matching.test.ts tests/entry-templates.test.ts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/954 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 4/29/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `nathan/rsc-route-matching-helper` --- ### 📝 Commits (1) - [`c9c39cd`](https://github.com/cloudflare/vinext/commit/c9c39cd2800856960913efab787abbbfd93d4196) test(app-router): update route matching delegation assertion ### 📊 Changes **1 file changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `tests/shims.test.ts` (+11 -8) </details> ### 📄 Description ## What this changes This updates the RSC route matching regression test now that the route/intercept matching runtime lives in `createAppRscRouteMatcher`. ## Approach - Keep the generated-entry assertion focused on delegation to `createAppRscRouteMatcher`. - Check the extracted route-matching helper source for accidental `decodeURIComponent(...)` calls so the no-double-decode invariant follows the new ownership boundary. ## Validation - `vp check tests/shims.test.ts` - `vp test run tests/shims.test.ts -t "RSC route matching does not double-decode pathnames"` - `vp test run tests/shims.test.ts tests/app-rsc-route-matching.test.ts tests/entry-templates.test.ts` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>