[PR #969] [MERGED] fix: align metadataRouteSuffix exemption list with Next.js #990

New issue

Closed

opened 2026-05-06 13:11:25 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:11:25 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/969
Author: @Divkix
Created: 4/29/2026
Status: ✅ Merged
Merged: 4/29/2026
Merged by: @james-elicx

Base: main ← Head: fix/963-metadata-suffix-inconsistency

📝 Commits (1)

c99f4ae fix: align metadataRouteSuffix exemption list with Next.js (#963)

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 packages/vinext/src/server/metadata-routes.ts (+4 -3)

📄 Description

Fixes #963

Summary

Removed extra robots and manifest exemptions from metadataRouteSuffix to match getMetadataRouteSuffix and Next.js
Both functions now only exempt sitemap from hash suffixes
The extra exemptions were latent (robots/manifest are root-only), but the inconsistency could cause bugs if nestable ever changes

Test plan

Existing tests/metadata-routes.test.ts (69 tests) pass
Existing tests/app-router.test.ts metadata tests pass

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/969 **Author:** [@Divkix](https://github.com/Divkix) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 4/29/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/963-metadata-suffix-inconsistency` --- ### 📝 Commits (1) - [`c99f4ae`](https://github.com/cloudflare/vinext/commit/c99f4ae1a49da09e53ad9254810b29de1aad5cb6) fix: align metadataRouteSuffix exemption list with Next.js (#963) ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/metadata-routes.ts` (+4 -3) </details> ### 📄 Description Fixes #963 ## Summary - Removed extra `robots` and `manifest` exemptions from `metadataRouteSuffix` to match `getMetadataRouteSuffix` and Next.js - Both functions now only exempt `sitemap` from hash suffixes - The extra exemptions were latent (robots/manifest are root-only), but the inconsistency could cause bugs if `nestable` ever changes ## Test plan - Existing `tests/metadata-routes.test.ts` (69 tests) pass - Existing `tests/app-router.test.ts` metadata tests pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>