[PR #970] [MERGED] fix: correct route-level boundary nesting order to match Next.js #993

New issue

Closed

opened 2026-05-06 13:11:27 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:11:27 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/970
Author: @Divkix
Created: 4/29/2026
Status: ✅ Merged
Merged: 4/29/2026
Merged by: @james-elicx

Base: main ← Head: fix/962-boundary-nesting-order

📝 Commits (1)

a96ccff fix: correct route-level boundary nesting order to match Next.js (#962)

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 packages/vinext/src/server/app-page-route-wiring.tsx (+7 -5)

📄 Description

Fixes #962

Summary

Swapped NotFoundBoundary and ErrorBoundary wrapping order at the route level in app-page-route-wiring.tsx
Next.js nests ErrorBoundary outermost relative to NotFoundBoundary; vinext had this inverted
The segment-level ordering was already correct; only the route-level code was fixed

Test plan

All existing tests pass: 321 app-router tests, 264 features tests, 528 nextjs-compat tests
Build, lint, format, and typecheck all pass

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/970 **Author:** [@Divkix](https://github.com/Divkix) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 4/29/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/962-boundary-nesting-order` --- ### 📝 Commits (1) - [`a96ccff`](https://github.com/cloudflare/vinext/commit/a96ccff1d542ac8fb964824ee3154f2c5c5381cc) fix: correct route-level boundary nesting order to match Next.js (#962) ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-page-route-wiring.tsx` (+7 -5) </details> ### 📄 Description Fixes #962 ## Summary - Swapped NotFoundBoundary and ErrorBoundary wrapping order at the route level in `app-page-route-wiring.tsx` - Next.js nests ErrorBoundary outermost relative to NotFoundBoundary; vinext had this inverted - The segment-level ordering was already correct; only the route-level code was fixed ## Test plan - All existing tests pass: 321 app-router tests, 264 features tests, 528 nextjs-compat tests - Build, lint, format, and typecheck all pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>