[PR #40] Fix border line with non-Islands themes and consistent panel spacing #100

New issue

Open

opened 2026-05-06 13:13:21 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:13:21 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/bwya77/vscode-dark-islands/pull/40
Author: @mervanhasancalik
Created: 2/16/2026
Status: 🔄 Open

Base: main ← Head: fix/border-line-and-panel-spacing

📝 Commits (1)

e1bc138 Fix border line with non-Islands themes and consistent panel spacing

📊 Changes

1 file changed (+11 additions, -5 deletions)

View changed files

📝 settings.json (+11 -5)

📄 Description

Border line appearing with non-Islands base themes

When users use a base theme like "Default Dark Modern", a vertical border line appears behind the floating sidebar.
This is because Dark Modern sets activityBar.border and sideBar.border to #2B2B2B. Adding transparent colorCustomizations prevents this.

Inconsistent panel spacing.

The sidebar, editor, and bottom panel had no bottom margins, causing them to be flush against the bottom Added consistent 8px margins so all floating islands have equal spacing on all sides, matching the existing top and side spacing.

Bottom panel tab clipping fix

Changed "overflow: hidden" to "overflow: clip" on the bottom panel to prevent the tab bar (Problems, Output, Terminal, etc.) from clipping when switching between panel views. "overflow: clip" provides the same visual clipping without interfering with VS Code's internal layout recalculations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bwya77/vscode-dark-islands/pull/40 **Author:** [@mervanhasancalik](https://github.com/mervanhasancalik) **Created:** 2/16/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/border-line-and-panel-spacing` --- ### 📝 Commits (1) - [`e1bc138`](https://github.com/bwya77/vscode-dark-islands/commit/e1bc138cad0fb4a6a247ce83a07f836173ecc099) Fix border line with non-Islands themes and consistent panel spacing ### 📊 Changes **1 file changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `settings.json` (+11 -5) </details> ### 📄 Description 1. Border line appearing with non-Islands base themes When users use a base theme like "Default Dark Modern", a vertical border line appears behind the floating sidebar. This is because Dark Modern sets activityBar.border and sideBar.border to #2B2B2B. Adding transparent colorCustomizations prevents this. 2. Inconsistent panel spacing. The sidebar, editor, and bottom panel had no bottom margins, causing them to be flush against the bottom Added consistent 8px margins so all floating islands have equal spacing on all sides, matching the existing top and side spacing. 3. Bottom panel tab clipping fix Changed "overflow: hidden" to "overflow: clip" on the bottom panel to prevent the tab bar (Problems, Output, Terminal, etc.) from clipping when switching between panel views. "overflow: clip" provides the same visual clipping without interfering with VS Code's internal layout recalculations. ![LineDarkModern](https://github.com/user-attachments/assets/995de9ff-941a-49ad-aa3b-af0b5875cb84) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>