[PR #89] [MERGED] Remove redundant `.tab .monaco-icon-label.file-icon::before` style rule #114

New issue

Closed

opened 2026-05-06 13:13:25 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:13:25 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/bwya77/vscode-dark-islands/pull/89
Author: @vrcalphabet
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @bwya77

Base: main ← Head: patch-1

📝 Commits (1)

6a9ca6d Remove duplicate style definition for .monaco-icon-label.file-icon::before

📊 Changes

1 file changed (+0 additions, -4 deletions)

View changed files

📝 settings.json (+0 -4)

📄 Description

This PR removes a duplicated style rule in settings.json.

The following two selectors defined the exact same styles:

.monaco-icon-label.file-icon::before
.tab .monaco-icon-label.file-icon::before

Since the scoped version under .tab did not add any additional behavior, it was redundant.
Removing it simplifies the theme settings without changing the visual output.

Closes #88

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bwya77/vscode-dark-islands/pull/89 **Author:** [@vrcalphabet](https://github.com/vrcalphabet) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@bwya77](https://github.com/bwya77) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`6a9ca6d`](https://github.com/bwya77/vscode-dark-islands/commit/6a9ca6dc8f6baedc68afab3843c4ff8ccc30ae37) Remove duplicate style definition for `.monaco-icon-label.file-icon::before` ### 📊 Changes **1 file changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `settings.json` (+0 -4) </details> ### 📄 Description This PR removes a duplicated style rule in `settings.json`. The following two selectors defined the exact same styles: - `.monaco-icon-label.file-icon::before` - `.tab .monaco-icon-label.file-icon::before` Since the scoped version under `.tab` did not add any additional behavior, it was redundant. Removing it simplifies the theme settings without changing the visual output. Closes #88 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>